From: Lars Ingebrigtsen <larsi@gnus.org>
To: Andrea Corallo <akrl@sdf.org>
Cc: Andrew Whatson <whatson@gmail.com>, 44209@debbugs.gnu.org
Subject: bug#44209: 28.0.50; [feature/native-comp] Compilation failure in progmodes/js.el
Date: Sun, 25 Oct 2020 17:13:01 +0100 [thread overview]
Message-ID: <87o8kq8esy.fsf@gnus.org> (raw)
In-Reply-To: <xjfpn56guxi.fsf@sdf.org> (Andrea Corallo's message of "Sun, 25 Oct 2020 15:57:29 +0000")
Andrea Corallo <akrl@sdf.org> writes:
>> I agree would be nice to have it tweaked for when we are not doing a
>> full AoT compilation.
>>
>> I'll have a look into.
>
> I pushed 868d3ff9b8, should do the job.
Thanks, looks good now. And it looks like this is erroring out not when
compiling js.el, but when cc-mode has been natively compiled?
$ make
....
make[2]: Entering directory '/home/larsi/src/emacs/native-compile/lisp'
ELC progmodes/js.elc
In toplevel form:
progmodes/js.el:4550:11: Error: Symbol’s function definition is void: cc-bytecomp-is-compiling
make[2]: *** [Makefile:318: progmodes/js.elc] Error 1
make[2]: Leaving directory '/home/larsi/src/emacs/native-compile/lisp'
make[1]: *** [Makefile:352: compile-main] Error 2
make[1]: Leaving directory '/home/larsi/src/emacs/native-compile/lisp'
make: *** [Makefile:420: lisp] Error 2
cc-bytecomp-is-compiling is a defsubst, if that's any clue. The
following patch fixes the problem, but I'm not sure... why...
diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index f3cfbbb948..563bf88e6a 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -48,6 +48,7 @@
(require 'cc-mode)
(eval-when-compile
(require 'cc-langs)
+ (require 'cc-bytecomp)
(require 'cc-fonts))
(require 'newcomment)
(require 'imenu)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-10-25 16:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 11:06 bug#44209: 28.0.50; [feature/native-comp] Compilation failure in progmodes/js.el Andrew Whatson
2020-10-25 13:16 ` Lars Ingebrigtsen
2020-10-25 13:52 ` Andrew Whatson
2020-10-25 14:25 ` Lars Ingebrigtsen
2020-10-25 14:42 ` Andrew Whatson
2020-10-25 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:11 ` Andrew Whatson
2020-10-25 15:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:02 ` Lars Ingebrigtsen
2020-10-25 15:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 16:13 ` Lars Ingebrigtsen [this message]
2020-10-25 21:43 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 23:06 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 23:44 ` Lars Ingebrigtsen
2020-10-26 1:08 ` Andrew Whatson
2020-10-26 7:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8kq8esy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=44209@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=whatson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.