From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: gnus-group-read-ephemeral-search-group -- Something Changed? Date: Fri, 06 Nov 2020 10:12:33 -0800 Message-ID: <87o8ka5p7y.fsf@ericabrahamsen.net> References: <20201106162239.1E8ECC20DCB@raman-glaptop.localdomain> <87wnyy5rkh.fsf@ericabrahamsen.net> <24485.36148.78621.877205@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31034"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Nov 06 19:13:28 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kb6Eq-0007yZ-61 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 19:13:28 +0100 Original-Received: from localhost ([::1]:44946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb6Ep-0000rA-97 for ged-emacs-devel@m.gmane-mx.org; Fri, 06 Nov 2020 13:13:27 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51468) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb6E5-0008S9-4R for emacs-devel@gnu.org; Fri, 06 Nov 2020 13:12:41 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:58126 helo=mail.ericabrahamsen.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb6E2-00038X-Eb for emacs-devel@gnu.org; Fri, 06 Nov 2020 13:12:40 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4D8D6FA086; Fri, 6 Nov 2020 18:12:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1604686355; bh=LtSdjJDFzBnnguCJWV+gbk5Y4f7tTn/hmp4Te5inmyc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aDJI6g3OLCKpzdDafTUvi90rOJYo8bD9Z/Yy0MuD4IqQjJfsUwvNHsSfiSlu3/AGV O9v3JJA27cG0ypX3IbArZOMmrhsbGLIXXe1UBMRSenSC5OJ6AcUo1HGKWlP7d0kjih Vx4CGHy2caTjUaMRWyqiVqsLAnZ7YbSuJz4780f4= In-Reply-To: <24485.36148.78621.877205@retriever.mtv.corp.google.com> (T. V. Raman's message of "Fri, 6 Nov 2020 09:51:48 -0800") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 11:01:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258838 Archived-At: "T.V Raman" writes: > you're correct. But please keep the backward compatibility, since I > need emacspeak to work with both the released emacs 27, as well as > emacs-28 built from head which I use --- that latter is what helps me > make sure that when Emacs-28 does get released, emacspeak works out of > the box with it. Okay, will do. Are you sure that checking for the nnir key symbol is enough to make everything work correctly? > > Eric Abrahamsen writes: > > "T.V Raman" writes: > >=20 > > > I use gnus-group-read-ephemeral-search-group to search GMail via ima= p, > > > see details in this blog article: > > > https://emacspeak.blogspot.com/2020/09/searching-gmail-from-gnus.html > > > > > > About 8 weeks or so, that function > > > gnus-group-read-ephemeral-search-group was declared obsolete but its > > > replacement was supposed to be backward compatible and everything > > > worked until about 2 days ago --- or from memory I updated/rebuilt > > > emacs yesterday and it's broken today. > > > > > > Broken: How, > > > > > > Now, when I invoke the afore-mentioned function > > > I get an additional prompt after supplying the query and calling it > > > with the imap-search spec it expects. A quick look in git logs didn't > > > show anything suspicious, other than the file was changed with > > > comments to the effect that that function is obsolete. > >=20 > > Yes, this function has changed in the past couple of days, as nnir.el > > has been obsoleted. I'm guessing you're calling > > `gnus-gorup-read-ephemeral-search-group' with a spec that contains an > > `nnir-search-spec' key? That key is now called `gnus-search-spec'. > >=20 > > I can provide better backwards compatibility by continuing to check for > > the `nnir-search-spec' and `nnir-group-spec' keys, I guess I didn't > > think people would be using that function programmatically in this way. > >=20 > > Would you be willing to show me exactly how you're calling this > > function? I can be more certain about providing backwards compatibility > > that way, and might be able to suggest some alterations. > >=20 > > Sorry for the roadbump, > >=20 > > Eric > > --=20 > =E2=99=89Id: kg:/m/0285kf1 =F0=9F=A6=AE=E2=99=89 "T.V Raman" writes: > P.S. how am calling that function was documented in the blog article I > mentioned; here is a pointer to the code in Git to make it easier. > https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L133 I'll take a look at this over the weekend. Maybe I can suggest some more changes to take advantage of the new gnus-search.el library. Thanks for the report, Eric