From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "T.V Raman" <raman@google.com>
Cc: emacs-devel@gnu.org
Subject: Re: gnus-group-read-ephemeral-search-group -- Something Changed?
Date: Fri, 06 Nov 2020 10:12:33 -0800 [thread overview]
Message-ID: <87o8ka5p7y.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <24485.36148.78621.877205@retriever.mtv.corp.google.com> (T. V. Raman's message of "Fri, 6 Nov 2020 09:51:48 -0800")
"T.V Raman" <raman@google.com> writes:
> you're correct. But please keep the backward compatibility, since I
> need emacspeak to work with both the released emacs 27, as well as
> emacs-28 built from head which I use --- that latter is what helps me
> make sure that when Emacs-28 does get released, emacspeak works out of
> the box with it.
Okay, will do. Are you sure that checking for the nnir key symbol is
enough to make everything work correctly?
> > Eric Abrahamsen writes:
> > "T.V Raman" <raman@google.com> writes:
> >
> > > I use gnus-group-read-ephemeral-search-group to search GMail via imap,
> > > see details in this blog article:
> > > https://emacspeak.blogspot.com/2020/09/searching-gmail-from-gnus.html
> > >
> > > About 8 weeks or so, that function
> > > gnus-group-read-ephemeral-search-group was declared obsolete but its
> > > replacement was supposed to be backward compatible and everything
> > > worked until about 2 days ago --- or from memory I updated/rebuilt
> > > emacs yesterday and it's broken today.
> > >
> > > Broken: How,
> > >
> > > Now, when I invoke the afore-mentioned function
> > > I get an additional prompt after supplying the query and calling it
> > > with the imap-search spec it expects. A quick look in git logs didn't
> > > show anything suspicious, other than the file was changed with
> > > comments to the effect that that function is obsolete.
> >
> > Yes, this function has changed in the past couple of days, as nnir.el
> > has been obsoleted. I'm guessing you're calling
> > `gnus-gorup-read-ephemeral-search-group' with a spec that contains an
> > `nnir-search-spec' key? That key is now called `gnus-search-spec'.
> >
> > I can provide better backwards compatibility by continuing to check for
> > the `nnir-search-spec' and `nnir-group-spec' keys, I guess I didn't
> > think people would be using that function programmatically in this way.
> >
> > Would you be willing to show me exactly how you're calling this
> > function? I can be more certain about providing backwards compatibility
> > that way, and might be able to suggest some alterations.
> >
> > Sorry for the roadbump,
> >
> > Eric
>
> --
> ♉Id: kg:/m/0285kf1 🦮♉
"T.V Raman" <raman@google.com> writes:
> P.S. how am calling that function was documented in the blog article I
> mentioned; here is a pointer to the code in Git to make it easier.
> https://github.com/tvraman/emacspeak/blob/master/lisp/gm-nnir.el#L133
I'll take a look at this over the weekend. Maybe I can suggest some more
changes to take advantage of the new gnus-search.el library.
Thanks for the report,
Eric
next prev parent reply other threads:[~2020-11-06 18:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 16:22 gnus-group-read-ephemeral-search-group -- Something Changed? T.V Raman
2020-11-06 17:21 ` Eric Abrahamsen
2020-11-06 17:51 ` T.V Raman
2020-11-06 18:12 ` Eric Abrahamsen [this message]
2020-11-06 18:29 ` T.V Raman
2020-11-06 17:53 ` T.V Raman
2020-11-06 18:13 ` Pankaj Jangid
2020-11-06 18:30 ` Eric Abrahamsen
2020-11-07 2:04 ` Pankaj Jangid
2020-11-07 5:33 ` Eric Abrahamsen
2020-11-07 6:01 ` Pankaj Jangid
2020-11-07 17:38 ` Eric Abrahamsen
2020-11-07 6:33 ` Stefan Monnier
2020-11-07 17:35 ` Eric Abrahamsen
2020-11-07 17:34 ` T.V Raman
2020-11-07 17:45 ` Eric Abrahamsen
2020-11-07 18:51 ` T.V Raman
2020-11-08 2:07 ` Eric Abrahamsen
2020-11-08 2:33 ` T.V Raman
2020-11-08 4:35 ` Eric Abrahamsen
2020-11-08 4:48 ` Stefan Monnier
2020-11-08 16:54 ` T.V Raman
2020-11-08 17:09 ` Eric Abrahamsen
2020-11-08 17:43 ` T.V Raman
2020-11-09 0:41 ` Eric Abrahamsen
2020-11-09 0:49 ` T.V Raman
2020-11-09 2:26 ` Eric Abrahamsen
2020-11-09 15:35 ` T.V Raman
2020-11-09 16:27 ` Eric Abrahamsen
2020-11-06 18:30 ` Eric Abrahamsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8ka5p7y.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
--cc=raman@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.