From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: What version of harfbuzz is required? Date: Thu, 12 Nov 2020 12:06:49 +0100 Message-ID: <87o8k2hm0m.fsf@gmail.com> References: <87tutvhoyg.fsf@yandex.com> <87sg9fhoba.fsf@gmail.com> <87pn4jhmrj.fsf@yandex.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22383"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Colin Baxter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 12 12:08:00 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdASN-0005iP-1r for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Nov 2020 12:07:59 +0100 Original-Received: from localhost ([::1]:43914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdASM-0003pH-4r for ged-emacs-devel@m.gmane-mx.org; Thu, 12 Nov 2020 06:07:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kdARM-0003Fr-U3 for emacs-devel@gnu.org; Thu, 12 Nov 2020 06:06:56 -0500 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:39115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kdARJ-0002VE-Jr for emacs-devel@gnu.org; Thu, 12 Nov 2020 06:06:56 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id o15so5548465wru.6 for ; Thu, 12 Nov 2020 03:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=oSdIXcgV9hwBMwPtsXEy93m0MJtei5VW9S6aTpa1/yE=; b=WSAmxL3dC8CI/GESOMh4COntphNmerDFYvPyZimghz3dZk+dyTdkrMeJ2BqsyyIzJ6 +ECWeQJLf8BkqbrEO+WxgY23cAS6d7PSulxig3zsFrzyxBmI/pjvEdNUpW1/nonQ4czy H3TUCXbNz+TYOVL28tlOhw/nd8Vo1JQijDQPDOp+quCEGPCv1ZuRc+wB04zvYakpmY4/ eDOBlQicpBHirZ41S5wbxcp2Vfr11/QLDN1F6RLidX/HumMVsvKSwVAJw4tH8za0bgQH vVhS5o39TEWnn1SjD4xhXB79JRxHUXdG31Votp7CjIv/AKCoxGhNR+8z5gvCHDVIKoo6 HHJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=oSdIXcgV9hwBMwPtsXEy93m0MJtei5VW9S6aTpa1/yE=; b=f80LYij5a1k91xKQxRgL7uyILvxld0KRYr9NDy4RWKDifiaFoSiqOGwbiR3oLq7uak 8VXV1gE9z1S28i3jMkDTJU5wtFIhI8ZsqFScP2DZvfzTiL/sSZP7rQeG2Jx32CmYt5tt JEwCX8if8Mg9JuxmNMe8h8Ph1uI3ZCe34CV1KYbuGmOwFXlMCTXN0zPdlk6OGI6TO/kb aoHzrtaBlxhnXpCmeWO2rK7JdSf+OC+ky7g+vjUq/e/MQDMuwoS6ofyUxMLVMpZEhNe2 TaryQxMEojydZOijbyZ3uBGq5xkLEltvpLQGSFFy74qbep6MOO3K67vGVg0AuX0VOGZt uztQ== X-Gm-Message-State: AOAM533hNVYtrOM3n+iTX3dnLW3of5YH9NNAvh8/u/M/H7I2ctxv4Nar 0mkW00vh0f+lK1bOS/WKqk/SsZcHcKM= X-Google-Smtp-Source: ABdhPJyLwaNk+JwMbZu5fd2OwbekOI+jWw8fxVqV2nWHa/u+93nahOlXx102xlmFOxTXeIi6QETvdw== X-Received: by 2002:adf:92e7:: with SMTP id 94mr37359276wrn.271.1605179211679; Thu, 12 Nov 2020 03:06:51 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a860:bc9f:3b53:dcc4:73ea]) by smtp.gmail.com with ESMTPSA id f7sm6870113wrx.64.2020.11.12.03.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:06:50 -0800 (PST) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87pn4jhmrj.fsf@yandex.com> (Colin Baxter's message of "Wed, 11 Nov 2020 16:38:24 +0000") Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=rpluim@gmail.com; helo=mail-wr1-x42c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:259073 Archived-At: Colin Baxter writes: > > and the configure output says: checking for harfbuzz >=3D > > 0.9.42... yes > > Ok, 0.9.42. I suppose it's time to bite the bullet and upgrade my > Debian. The non-HarfBuzz code is still functional, and won't go away for a while yet. > > > I guess we could put the version in the warning as well, but it > > seems a little excessive. > > It could be useful in avoiding eye strain in searching the configure > output for a mention of 'harfbuzz' :-) You don=CA=BCt run ./configure in a shell inside emacs? ;-) Eli, something like this OK for master? diff --git i/configure.ac w/configure.ac index f0c8e5210f..888b415148 100644 --- i/configure.ac +++ w/configure.ac @@ -3444,16 +3444,17 @@ AC_DEFUN fi # "${HAVE_X11}" !=3D "yes" =20 HAVE_HARFBUZZ=3Dno +### On MS-Windows we use hb_font_get_nominal_glyph, which appeared +### in HarfBuzz version 1.2.3 +if test "${HAVE_W32}" =3D "yes"; then + harfbuzz_required_ver=3D1.2.3 +else + harfbuzz_required_ver=3D0.9.42 +fi if test "${HAVE_X11}" =3D "yes" && test "${HAVE_FREETYPE}" =3D "yes" \ || test "${HAVE_W32}" =3D "yes"; then if test "${with_harfbuzz}" !=3D "no"; then - ### On MS-Windows we use hb_font_get_nominal_glyph, which appeared - ### in HarfBuzz version 1.2.3 - if test "${HAVE_W32}" =3D "yes"; then - EMACS_CHECK_MODULES([HARFBUZZ], [harfbuzz >=3D 1.2.3]) - else - EMACS_CHECK_MODULES([HARFBUZZ], [harfbuzz >=3D 0.9.42]) - fi + EMACS_CHECK_MODULES([HARFBUZZ], [harfbuzz >=3D $harfbuzz_required_ver]) if test "$HAVE_HARFBUZZ" =3D "yes"; then AC_DEFINE(HAVE_HARFBUZZ, 1, [Define to 1 if using HarfBuzz.]) ### mingw32 and Cygwin-w32 don't use -lharfbuzz, since they load @@ -5918,9 +5919,9 @@ m4_define =20 if test "${HAVE_CAIRO}" =3D "yes" && test "${HAVE_HARFBUZZ}" =3D no; then AC_MSG_WARN([This configuration uses the Cairo graphics library, - but not the HarfBuzz font shaping library. We recommend the use - of HarfBuzz when using Cairo, please install HarfBuzz development - packages.]) + but not the HarfBuzz font shaping library (minimum version $harfbuzz_r= equired_ver). + We recommend the use of HarfBuzz when using Cairo, please install + appropriate HarfBuzz development packages.]) fi =20 # Let plain 'make' work.