From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#33341: 27.0.50; Undo log merging and change groups Date: Thu, 26 Nov 2020 15:49:29 +0100 Message-ID: <87o8jkgoli.fsf@web.de> References: <877ehk3ve4.fsf@web.de> <87blfkthy7.fsf@gnus.org> <87zh3442zo.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40025"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , 33341@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 26 15:50:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kiIb4-000AJK-4c for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 15:50:10 +0100 Original-Received: from localhost ([::1]:35976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kiIb3-00020o-1M for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Nov 2020 09:50:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39072) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kiIaw-00020h-1U for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57172) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kiIav-0006sb-Pf for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:50:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kiIav-0000Vq-OB for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2020 09:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Nov 2020 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33341 X-GNU-PR-Package: emacs Original-Received: via spool by 33341-submit@debbugs.gnu.org id=B33341.16064021841942 (code B ref 33341); Thu, 26 Nov 2020 14:50:01 +0000 Original-Received: (at 33341) by debbugs.gnu.org; 26 Nov 2020 14:49:44 +0000 Original-Received: from localhost ([127.0.0.1]:40485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIad-0000VG-Q2 for submit@debbugs.gnu.org; Thu, 26 Nov 2020 09:49:43 -0500 Original-Received: from mout.web.de ([212.227.17.12]:52301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiIaa-0000V1-W8 for 33341@debbugs.gnu.org; Thu, 26 Nov 2020 09:49:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1606402171; bh=X/Ejf7Ty5JlOLIDzS2ySpXAVqSTOaqyb3r1pVJWoLRU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=K0W8IY5Us6eVi+OtOa5xjETb9Yp4ehn+zIfW6xftscuGpXtDLFPmJO//OfjFFDoDW V3hg+XzDF32ZX9lzk0Uzsa2FnGs+2zM/RBACPavmHDDUQEbwYNAiKGdLbQPtAKLPjV rvYP/de4yvmywcR6o9JRuHpxnL11xdYO7cmxVCK0= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.219.247]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LuuNx-1kHSGI0tKj-0106uM; Thu, 26 Nov 2020 15:49:31 +0100 In-Reply-To: <87zh3442zo.fsf@web.de> (Michael Heerdegen's message of "Thu, 26 Nov 2020 15:16:59 +0100") X-Provags-ID: V03:K1:MCum+x1mMcyBavJheee3Aw9MEs6fffEBJMTicii5ERh5elmHFO2 DAvrWKiorg9AQQRUWTRdKFHcyl87NdDPlJpJucPFiWr1Co+ssQJiImpu+w7NVYsLfXURRYz VFl0u0CcXVdhrUDG+rBxilRFVYofJEcv9moLBfFGq6csTi5K4lz4i4VVpjBQexA3HPh+x46 UBLbt+Snfg1PttdNOzxvQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:4tZ7OrC619s=:2N2BADsrAOnJV9W0XwkH50 udVtPGxuXWyigoeaMnEqGRvCz6poMcrGSSwciE4+vQki8nwM2mpz2LiCLg4of/TqU878w4Mt8 56fZSRP4mgv2rhXUvGASKoQedTw6i4lpcQQS6EbABqorTj/ryubDu73wa/PSVfxFqxoltYP+Y rcYmFsbse31tiMObNGDwsD50bLiEHsqywEF0oFbYiMwFZjoplqtXes1YohVszz1iQdlF3ub99 43eyUFMKi7KBALJeGJwufN/fRbeWKHMOu1fL4LBBuVDC4Ujos/ugSlHjQ8dXS+JgvqmK036tj SX7z9Zu0ZzM6M5+y21jD9d/GzGpxSi6Fu2/q+peGwPWp/h3tzktD830zPx8I6TCkYIh3NqbBr HDl3mbmIYzbrjO36G+Z7OekF9q/pSNb3yXCXLhdY1t9i+RrCQcaTxJmNoHDCmuzc5DJPb4Pid 4V0tfxAW67CHlyiOHSZ2BlOXirmgI+ZL2wMIH2kubT4AD5DdY3F0kUU0eAFXpaHzH3gbvRmVn lysH50gGjl/k/PIT2RYedRXrgk0QwurfhKyS70rqDFGhoQ1Am0veO8i0yQn1ashlxYoZ3NwD0 rpT+ahNGeQsCiLaDrbGDEOV50816g6TYaBCnYNXXFuDQU90BV8SEs3xqhGEPPQh0DMW5NBmsO t9g/egJMxYAGsATJ0WOGYuN0oCcvsBfApfp79Mgshn05YgjB41PJvBdk4M/qR27Unx1T6oVCG 3B2fneawMXBeq1QrBNcQaDdsiPUgyKz1HgM52bbJlTN9Tc5zqTSV3OcE4Nv4Sys4ykvwI7dp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194338 Archived-At: Michael Heerdegen writes: > Lars Ingebrigtsen writes: > > > Hm... Well, after running this command, hitting "undo" removes all the > > three lines, which is what I'd expect? Since you cancelled the change > > group? > > AFAIU `cancel-change-group' itself should undo the change set, without > the user invoking `undo'. See the implementation of > `atomic-change-group' for a use of this feature. BTW, coming back to my example: #+begin_src emacs-lisp (defun my-test-change-groups () (interactive) (insert "0\n") ;; try to comment this line (let ((g (prepare-change-group))) (activate-change-group g) (insert "b\n") (insert "c\n") (cancel-change-group g))) #+end_src if you comment the line including the `insert' call before the change group is prepared the thing works as expected. So there is a problem with this insertion (in the same command?) before preparing the group, or this is actually not allowed but not documented accordingly. Michael.