all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Two fixes for module bug when interleaving threads
Date: Sun, 29 Nov 2020 21:44:19 +0200	[thread overview]
Message-ID: <87o8jgvtxg.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAArVCkTijzgpi=Pku7SpK1UeCPsMbYHBEaWjjFJ+H4A4e-uhWw@mail.gmail.com> (Philipp Stephani's message of "Fri, 27 Nov 2020 21:57:41 +0100")

> I just pushed two fixes for the same bug that appears when
> interleaving module calls in separate threads:
> cdc632fbe6e149318147a98cccf1b7af191f2ce8 for the release branch and
> 23974cfa48b9245658667eff81d132b3aecd2618 for master. The intention was
> that a simpler and more localized fix should go to the release branch,
> the "proper" fix to master. Now I've realized that arguably the
> simpler fix is overall better: it's more localized, touches fewer
> moving pieces, and is probably not significantly slower (though I
> haven't benchmarked it). Any opinions? If people agree, we can
> overwrite the fix on master with the fix on the release branch.

Unfortunately, 23974cfa48b9245658667eff81d132b3aecd2618 in master
broke module loading: while loading a module, Emacs prints the
message "Loading (module)..." and hangs, doesn't react to input,
becomes completely unresponsive to C-g.

Here's is the shortest reproducible test case:

M-x package-install RET zmq RET
(load-file "~/.emacs.d/elpa/zmq-20200912.1126/emacs-zmq.so")

It hangs after printing to stderr:

  double free or corruption (!prev)
  Fatal error 6: Aborted

Fortunately, this problem doesn't exist in the 27 release branch.



  parent reply	other threads:[~2020-11-29 19:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 20:57 Two fixes for module bug when interleaving threads Philipp Stephani
2020-11-28  7:25 ` Eli Zaretskii
2020-11-29 19:44 ` Juri Linkov [this message]
2020-11-29 20:16   ` Philipp Stephani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8jgvtxg.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=emacs-devel@gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.