From: Lars Ingebrigtsen <larsi@gnus.org>
To: Matt Armstrong <matt@rfc20.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 46819@debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Wed, 10 Mar 2021 15:54:30 +0100 [thread overview]
Message-ID: <87o8frjbyx.fsf@gnus.org> (raw)
In-Reply-To: <874khj8v9c.fsf@rfc20.org> (Matt Armstrong's message of "Tue, 09 Mar 2021 20:53:19 -0800")
Matt Armstrong <matt@rfc20.org> writes:
> How about we fix benchmark's use of `let', and leave the warning in
> place. It does not seem to be generating many other complaints, so it
> may not be particularly annoying after all. I'm currently working with
> `benchmark-run' a bunch and would like the warning gone from that one
> use.
>
> I can make a patch, but a one liner might be quicker for one of you to
> just commit directly. ;-)
Yup; now done.
I think we should keep the byte-compilation warning -- at least for
now. If it leads to false positives all over the place, then perhaps
not, but it's a useful warning, in my opinion.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-03-10 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 20:18 bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Matt Armstrong
2021-02-27 21:00 ` Stefan Monnier
2021-02-28 14:13 ` Lars Ingebrigtsen
2021-03-01 0:04 ` Matt Armstrong
2021-03-01 0:09 ` Lars Ingebrigtsen
2021-03-01 0:19 ` Lars Ingebrigtsen
2021-03-01 5:04 ` Stefan Monnier
2021-03-02 5:07 ` Matt Armstrong
2021-03-10 4:53 ` Matt Armstrong
2021-03-10 14:54 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8frjbyx.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=46819@debbugs.gnu.org \
--cc=matt@rfc20.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.