From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Tue, 25 May 2021 09:39:15 +0100 Message-ID: <87o8czgqbw.fsf@gmail.com> References: <87zgwlb4xc.fsf@gmail.com> <617d06ca-27bf-2ae8-26eb-1042123499d3@daniel-mendler.de> <87pmxhb1rs.fsf@gmail.com> <23510125-37b9-e87e-3590-5322f44772ce@daniel-mendler.de> <87a6olazff.fsf@gmail.com> <93d2cfe9-bae8-bf94-486f-7569aa31491d@daniel-mendler.de> <87bl8zivzj.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21448"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler , Juri Linkov , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 25 10:40:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llSbh-0005Mf-Pt for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 10:40:09 +0200 Original-Received: from localhost ([::1]:32802 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llSbg-0003nW-QS for ged-emacs-devel@m.gmane-mx.org; Tue, 25 May 2021 04:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llSax-0002rr-2f for emacs-devel@gnu.org; Tue, 25 May 2021 04:39:23 -0400 Original-Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:53073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llSat-00076V-MQ for emacs-devel@gnu.org; Tue, 25 May 2021 04:39:22 -0400 Original-Received: by mail-wm1-x32e.google.com with SMTP id z130so16253678wmg.2 for ; Tue, 25 May 2021 01:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=lbIZ75UvGyWdnqEBwgTDwg2MY73n/a72Dsi3RvyGW2s=; b=Gpk+uea7nLnbPK09vwkqSYdajlkVFC61MREPGwvgK+oSYaz1Cem5smolo7dllqANMZ zG8UV6pn3WVhma19Nu9OJgmnnWGq2RRoCEIUSps6UpDvcdfqfWDPxR+RUNZocaE37EQG 3TMwA8Bz1pagpkLWithXuj/S5omi/zzg6W5yaZfsdTN3j/zxDVYhoRltxjItjTAIseRc wpI8flnSv/i02KJIGdfcnwjoKMnhZoKhpsMqHEH6P+xFb4E2zzZI/wqo1Pyx8nOQ8rbu I5HD5gCksQ2cyCP3Uy8UmUwUnH1lnpLDC+mnNy8HS/nOE1rOP+AuneywmSYB48DJhiTM MPjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=lbIZ75UvGyWdnqEBwgTDwg2MY73n/a72Dsi3RvyGW2s=; b=IKccEW9a1v21766LIKw9QasvethU66dQRmfOJGihyhBO2C0hESUHhWpBkR8IHmw2w1 QRSvDr7P6faOIQrPelUo3Og7pMGZx+lcR5LAfX5WS0b36L6wDY1fbVcCbB4fn7z4hPWg uF4MJ2U2z6yOzJ8S3wxbDGveGFO2NVhvW94v3m943e4tKGoD1ld4J/CCT6TdG0R0bkpu ujRldb6GAQeNfXA6OQP1usqBOUvMo3qZkanlhVrTcKWjIXUVUc4fLYDFJIh1SwyNoluG y7b5uYTHZpCTp/b7jswKwNpQPALmnPvs9F0DxnDKkTb9z064ptu4I+3Eg4Ltp08xMTSZ Z5tQ== X-Gm-Message-State: AOAM5335SIjWds7rmN9qgIxMUjsphjPEXp38nPMaXHC1wiJqT60uxU+a r1Vl2NPzbw+RVuSTo6D00rU= X-Google-Smtp-Source: ABdhPJyGjUSI+HVLLYmTtTWMVneNyksyfc+Fw2GnrQt/FMrt4wzwcwfn16IsKaFYiwqD0rnoi4A6Fw== X-Received: by 2002:a1c:7313:: with SMTP id d19mr23016455wmb.14.1621931957856; Tue, 25 May 2021 01:39:17 -0700 (PDT) Original-Received: from krug (a94-133-55-152.cpe.netcabo.pt. [94.133.55.152]) by smtp.gmail.com with ESMTPSA id p5sm15982851wrd.25.2021.05.25.01.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 01:39:17 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Mon, 24 May 2021 21:38:29 -0400") Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=joaotavora@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269841 Archived-At: Stefan Monnier writes: > - We're not in the business of preventing people from shooting > themselves in the foot, so I think it's fine to pass the whole list of > completion and receive a whole list of annotated completions, even if > that runs the risk of receiving a list in a different order or with > different elements: we can document the expected behavior and just not > worry about the sneaky guys. Who knows: those sneaky guys may end up > finding an actually good use for it. Extremely unlikely. More likely the sneak would work fine for one frontend, but break another one. I don't have extremely strong views here either, but as an API user, I distrust endpoints that allow silly stuff and then warn "don't! undefined consequences" in the docs. It's much friendlier if there is one less way to mess up, especially when developing. > - For performance reasons it should be OK to call the "affixotation" > function one element (or a small number of elements) at a time, so we > only do it for those completions which are actually displayed. > So this function should not presume that it always receives the complete > lists of completions. But here again, this seems to be a small matter > of documentation. If it's OK to call it one at a time, the zorglubization function should take one completion at a time, no transcendental presumption needed. Jo=C3=A3o