From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#47300: delete-window to select window with same position Date: Fri, 04 Jun 2021 00:20:32 +0300 Organization: LINKOV.NET Message-ID: <87o8cmwrsf.fsf@mail.linkov.net> References: <87a6qw43gg.fsf@mail.linkov.net> <87pmxodrmq.fsf@gnus.org> <7f870f9b-95ad-6b5d-82aa-1bcfe5cc880a@gmx.at> <87fsyk0w92.fsf@mail.linkov.net> <2ec3b911-4fb1-4b13-a5b8-28278a5c43ba@gmx.at> <87h7iyzvh5.fsf@mail.linkov.net> <0c239adb-e9d5-1fe9-4c4c-2da1603002f7@gmx.at> <87mtsmmpey.fsf@mail.linkov.net> <1032ab23-3905-1b3f-917c-60ccd12337b3@gmx.at> <87v9752n4r.fsf@mail.linkov.net> <63612145-5eaa-0766-30cc-f30f7e7e1700@gmx.at> <87k0nefwq6.fsf@mail.linkov.net> <6f37ba16-527b-4537-116c-b215a9f39d1b@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20992"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 47300@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 04 00:00:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lovNw-0005Gf-69 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 00:00:16 +0200 Original-Received: from localhost ([::1]:34550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lovNv-00017k-7s for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 18:00:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lov9C-0005OS-Hd for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 17:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lov9C-0003Ia-7H for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 17:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lov9C-0006gj-52 for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 17:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47300-submit@debbugs.gnu.org id=B47300.162275667125650 (code B ref 47300); Thu, 03 Jun 2021 21:45:02 +0000 Original-Received: (at 47300) by debbugs.gnu.org; 3 Jun 2021 21:44:31 +0000 Original-Received: from localhost ([127.0.0.1]:44942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lov8h-0006fe-0E for submit@debbugs.gnu.org; Thu, 03 Jun 2021 17:44:31 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:3991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lov8e-0006fO-Jo for 47300@debbugs.gnu.org; Thu, 03 Jun 2021 17:44:29 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 9904A240003; Thu, 3 Jun 2021 21:44:19 +0000 (UTC) In-Reply-To: <6f37ba16-527b-4537-116c-b215a9f39d1b@gmx.at> (martin rudalics's message of "Wed, 2 Jun 2021 11:08:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207974 Archived-At: > I called them just 'mru' and 'pos' now. The option is called > `selected-window-after-deletion', there might be better names. Maybe better with the same name prefix as `delete-window'? For example, `delete-window-select'? But the current is also fine. > Please have a look. Thanks, I tested out, and everything works nicely. Only minor remarks: > +(defun get-mru-window (&optional all-frames dedicated not-selected no-other) > +non-nil means never return the selected window. Optional > +argument NO_OTHER non-nil means to never return a window whose Typo: NO-OTHER > +(defcustom selected-window-after-deletion 'mru Not strictly necessary now, but for future extensions would it be possible to allow this option to be customized to a function that selects a window? > + :type '(choice (const :tag "Most recently used" mru) > + (const :tag "At position" pos) > + nil) This 'nil' needs to be replaced with a list like: (const :tag "First window" nil) > + ;; If we deleted the selected window of WINDOW's frame, choose > + ;; another one based on `selected-window-after-deletion'. Note > + ;; that both `window-at-pos' and `get-mru-window' mail fail to ========= Typo.