From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#49124: Wdired doesn't like re-search-forward/replace-match Date: Sun, 20 Jun 2021 03:28:56 +0200 Message-ID: <87o8c1b9yf.fsf@web.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49124@debbugs.gnu.org To: Eduardo Ochs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 20 03:30:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lumHr-000ASE-8W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Jun 2021 03:30:11 +0200 Original-Received: from localhost ([::1]:59978 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lumHp-0007XH-W4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Jun 2021 21:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lumHi-0007Ws-Ox for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 21:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lumHi-0005sZ-Fu for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 21:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lumHi-0004qI-A4 for bug-gnu-emacs@gnu.org; Sat, 19 Jun 2021 21:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Jun 2021 01:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49124 X-GNU-PR-Package: emacs Original-Received: via spool by 49124-submit@debbugs.gnu.org id=B49124.162415254518522 (code B ref 49124); Sun, 20 Jun 2021 01:30:02 +0000 Original-Received: (at 49124) by debbugs.gnu.org; 20 Jun 2021 01:29:05 +0000 Original-Received: from localhost ([127.0.0.1]:32867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lumGn-0004og-9e for submit@debbugs.gnu.org; Sat, 19 Jun 2021 21:29:05 -0400 Original-Received: from mout.web.de ([212.227.17.12]:50099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lumGl-0004o9-HO for 49124@debbugs.gnu.org; Sat, 19 Jun 2021 21:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1624152537; bh=mIQy5ykfyI15AWUFLClUxtqDKPy2Yq8aEOiwneSC6Cc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=JhRBbZmbXM3t19HK4ORwU+2WJ/aCU1CKTolGGQy2/yWUgPgtY2rQx07yWjFiCPNKx Jzs84yiI4q54ybwf6wea4S3svIXpdH6uKrY4Pgu8kb8R3x6W4TAOPkvYFzX2z8sOvD YzFKmgHWQsK0Tdqc9tFfI9yJas9mj90d2E6q/qXs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([178.6.28.242]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M5g0a-1l65Ls3HmC-00xdyf; Sun, 20 Jun 2021 03:28:56 +0200 In-Reply-To: (Eduardo Ochs's message of "Sat, 19 Jun 2021 21:33:37 -0300") X-Provags-ID: V03:K1:CNl90CBlkRfCY7sIEpgt8PsBBFg0TCy2iX25m1ZLWoD/rsXwPC1 GOytMlM8pvTLZO45X/SZTrCUXDUr3HNj0Q7MGdp7lqWvCU8EdP9zrpgAAirEpzTFhLxufAV yP67P6Sc8MMr7CCo2s+AyIoAe/N4lzMWkU7CFuHS3jDOau9KVe/onOX1fzQesXVraxLsMiv /HyJ/N0DRzPc7n7hTXTyg== X-UI-Out-Filterresults: notjunk:1;V03:K0:CnrauW9fgvk=:1tKBpjVUrb6cRTQeINBi+w xZl6Cn19eTeGF88eTlb8vqkaKtRRptYoosk13Hy/CLt5fxiqv16jNJnLSQLbpFaX26+TzXzHb lnsTQnVzoTed9IJQ88MzpSJGBCZ5ygxcqF3wTxY3NMIijdmxCP5NqDnwxl8YO7EtTaXOCylcu DpGTfSwlheYVNcNX5ChYmS3ouzu3MQ1m00slQMFv2eYyGZf/VpH2CSOW24G4cd8XXRjMBSVU4 oMzybjnwsnhmD1cWceuBcc09kwRwyV9f/yoUZg80RHEz0iYfLN0bmpglYwQYqGtLACrXk6D9j iR2BDIOfoQdF/HEvhch1Y+gRVvvRy+6OAANPEx4V9W6qOpVBXgp0oSx4BdDAdwqHCzwIA9Oja O9jl9ebL+crIUigrHSpFhBd5sE8z5bNdqX4VZKAOUnH2mFmrwxdyDnddIdQo8frZ88XU0l1DD Eq9yQgjID5RDzDTQbBQNsIKFXRjplymKaeGLTcIjor8djQPufjhmEHJW6Qo/L1111UA2pRYt7 vSJkIZ8/TsQXLvp2QDfiOKJgxyehW9jzl/G/M7KaINtV41AOh8Dj8QH62ujOfByS1C4FROwMH qE4aObZmQjiIu2tf/zOcy9/bukZ+UQKp+Ou8YCYXva2ffQsmL1fZgkBU2UgeH38nEcaUcIJm+ 8828+3vOINcVhoFUDf/AIkSCLgkO0X+s18wmav3zWVVuJ5v166VOmJlQ5vvCJcLL7KIYXolZx tT9ui2SCsc7e6C0Kbs3gmusUlrlTuKj8++yaYwoSzr0FgCcoPnSmxhifSJWM5QWYolNlmVMn X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208779 Archived-At: Eduardo Ochs writes: > Here's how to see the bug in action. Define `foo' by executing this > defun: > > (defun foo (s e) > "Replace all `a's by `b's in the region." > (interactive "r") > (save-excursion > (save-restriction > (narrow-to-region s e) > (goto-char (point-min)) > (while (re-search-forward "a" nil 'noerror) > (replace-match "b" 'fixedcase 'literal))))) > [...] I can reproduce the issue. The culprit seems to be `narrow-to-region' which seems to confuse the functions wdired now installs in the before and/or after change hooks (they expect at least complete lines) -- because this version: (defun foo (s e) "Replace all `a's by `b's in the region." (interactive "r") (save-excursion (save-restriction ;; (narrow-to-region s e) (goto-char s) (while (re-search-forward "a" e 'noerror) (replace-match "b" 'fixedcase 'literal))))) works as expected. I guess we should just temporarily `widen' in these functions. Michael.