bug#24467: 25.1; package

bug#24467: 25.1; package

[SK Kim]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

After i set gnu and mepla for pacakage-archives in my init.el as
below,

(package-initialize)
(setq package-archives
    '(("gnu" . "http://elpa.gnu.org/packages/")
     ("melpa" . "http://melpa.milkbox.net/packages/")))

whenever i start package-list-packages, status of mepla packages is
always new.

thanks.

[-- Attachment #2: Type: text/html, Size: 559 bytes --]

bug#24467: 25.1; package

[Noam Postavsky]

merge 24467 21703
quit

On Mon, Sep 19, 2016 at 1:29 AM, SK Kim <tttuuu888@gmail.com> wrote:
> After i set gnu and mepla for pacakage-archives in my init.el as
> below,
>
> (package-initialize)
> (setq package-archives
>     '(("gnu" . "http://elpa.gnu.org/packages/")
>      ("melpa" . "http://melpa.milkbox.net/packages/")))
>
> whenever i start package-list-packages, status of mepla packages is
> always new.

Seems to be the same as #21703 "25.0.50; package.el: Thousands of new
packages each day", but I'm not able to reproduce.

I put the above as my init.el in a temporary HOME dir, when I run
package-list-packages melpa packages are all "available" for me.

  0blayout           20160919.823  available  melpa      Layout
grouping with ease
  2048-game          20151026.1233 available  melpa      play 2048 in Emacs
  4clojure           20131014.1507 available  melpa      Open and
evaluate 4clojure.com questions
  @                  20140707.520  available  melpa
multiple-inheritance prototype-based objects DSL
...

bug#24467: 25.1; package

[Michael Heerdegen]

Noam Postavsky <npostavs@users.sourceforge.net> writes:

> merge 24467 21703
> quit
>
> On Mon, Sep 19, 2016 at 1:29 AM, SK Kim <tttuuu888@gmail.com> wrote:
> > After i set gnu and mepla for pacakage-archives in my init.el as
> > below,
> >
> > (package-initialize)
> > (setq package-archives
> >     '(("gnu" . "http://elpa.gnu.org/packages/")
> >      ("melpa" . "http://melpa.milkbox.net/packages/")))
> >
> > whenever i start package-list-packages, status of mepla packages is
> > always new.
>
> Seems to be the same as #21703 "25.0.50; package.el: Thousands of new
> packages each day", but I'm not able to reproduce.
>
> I put the above as my init.el in a temporary HOME dir, when I run
> package-list-packages melpa packages are all "available" for me.

Maybe it is different on the first run?

Hmm, anyway, I found out that with

 (package-initialize)
 (setq package-archives
     '(("gnu" . "http://elpa.gnu.org/packages/")
      ("melpa" . "http://melpa.milkbox.net/packages/")))

in my init file I see the issue.  But with

  (setq package-archives
        '(("gnu" . "http://elpa.gnu.org/packages/")
          ("melpa" . "http://melpa.milkbox.net/packages/")))
  (package-initialize)

it seems to be fixed (i.e. the same expressions just transposed).  With
other words, `package-archives' seemingly needs to be set before calling
`package-intialize' (@SK Kim, do you see the same?).

With the first version, after Emacs startup, `package-archive-contents'
only includes the "gnu" packages.  With the second version, it seems to
include "everything" (the list is too long to be printed in reasonable
time).  That variable is used to decide what packages are new.  That's
were the problem seems to come from.

I think the behavior is at least "surprising", a pitfall.


Regards,

Michael.

bug#24467: 25.1; package

[npostavs]

tags 24467 confirmed
severity 24467 minor
quit

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Noam Postavsky <npostavs@users.sourceforge.net> writes:
>>
>> I put the above as my init.el in a temporary HOME dir, when I run
>> package-list-packages melpa packages are all "available" for me.
>
> Maybe it is different on the first run?

Yes, if I close and reopen Emacs, then I see the "new" packages too.

>
> Hmm, anyway, I found out that with
>
>  (package-initialize)
>  (setq package-archives
>      '(("gnu" . "http://elpa.gnu.org/packages/")
>       ("melpa" . "http://melpa.milkbox.net/packages/")))
>
> in my init file I see the issue.  But with
>
>   (setq package-archives
>         '(("gnu" . "http://elpa.gnu.org/packages/")
>           ("melpa" . "http://melpa.milkbox.net/packages/")))
>   (package-initialize)
>
> it seems to be fixed (i.e. the same expressions just transposed).  With
> other words, `package-archives' seemingly needs to be set before calling
> `package-intialize' (@SK Kim, do you see the same?).

Ah, so the packages are "new" in the sense that they come from archives
added after package-initialize was called.

>
> With the first version, after Emacs startup, `package-archive-contents'
> only includes the "gnu" packages.  With the second version, it seems to
> include "everything" (the list is too long to be printed in reasonable
> time).  That variable is used to decide what packages are new.  That's
> were the problem seems to come from.
>
> I think the behavior is at least "surprising", a pitfall.

Would be nice to avoid it, indeed.

bug#24467: 25.1; package

[Michael Heerdegen]

npostavs@users.sourceforge.net writes:

> Ah, so the packages are "new" in the sense that they come from
> archives added after package-initialize was called.

I'm not sure whether this is by design and if we would break something
if we changed it.  I think the fix would be quite trivial: simply
speaking, we would change `package-read-all-archive-contents' to iterate
over "$package-user-dir/archives/*" instead of `package-archives'.


Michael.

bug#24467: 25.1; package

[Stefan Monnier]

>> Ah, so the packages are "new" in the sense that they come from
>> archives added after package-initialize was called.
>
> I'm not sure whether this is by design and if we would break something
> if we changed it.  I think the fix would be quite trivial: simply
> speaking, we would change `package-read-all-archive-contents' to iterate
> over "$package-user-dir/archives/*" instead of `package-archives'.

It's clearly a bug, and it's made worse in Emacs-27 where
package-initialize is called automatically before reading ~/.emacs.

IOW, I think "this" needs to be fixed before Emacs-27.1.

The fix you propose might work (tho with unintended side effects), but
I don't see any reason why we need to package-read-all-archive-contents
so early on anyway.  More specifically, package-activate-all should be
changed so it doesn't end up running package-read-all-archive-contents:
it's already the case when a package-quickstart-file is found, but if
there's no such file we call package-initialize which ends up calling
package-read-all-archive-contents even though we're only interested in
the package-load-all-descriptors part, really.


        Stefan

bug#24467: 25.1; package

[Stefan Monnier]

> It's clearly a bug, and it's made worse in Emacs-27 where
> package-initialize is called automatically before reading ~/.emacs.
> IOW, I think "this" needs to be fixed before Emacs-27.1.

I just installed a patch which should reduce the impact of this problem
in Emacs-27.1: the problem still occurs if you setq package-archives
after calling package-initialize, but at least you can now setq
package-archives in your ~/.emacs rather than having to do it in your
early-init.el.


        Stefan

bug#21703: adding package archives after calling package-initialize lists all their packages as "new"

[Lars Ingebrigtsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> It's clearly a bug, and it's made worse in Emacs-27 where
>> package-initialize is called automatically before reading ~/.emacs.
>> IOW, I think "this" needs to be fixed before Emacs-27.1.
>
> I just installed a patch which should reduce the impact of this problem
> in Emacs-27.1: the problem still occurs if you setq package-archives
> after calling package-initialize, but at least you can now setq
> package-archives in your ~/.emacs rather than having to do it in your
> early-init.el.

Is there more to be done here, or is this a sufficient solution to the
issue?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#24467: bug#21703: adding package archives after calling package-initialize lists all their packages as "new"

[Michael Heerdegen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
> >> It's clearly a bug, and it's made worse in Emacs-27 where
> >> package-initialize is called automatically before reading ~/.emacs.
> >> IOW, I think "this" needs to be fixed before Emacs-27.1.
> >
> > I just installed a patch which should reduce the impact of this problem
> > in Emacs-27.1: the problem still occurs if you setq package-archives
> > after calling package-initialize, but at least you can now setq
> > package-archives in your ~/.emacs rather than having to do it in your
> > early-init.el.
>
> Is there more to be done here, or is this a sufficient solution to the
> issue?

If nothing more was changed, then the originally reported problem is not
fixed.  That behavior might still annoy or confuse people then.

Michael.