From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function` Date: Sun, 22 Aug 2021 16:44:09 +0100 Message-ID: <87o89peb7a.fsf@gmail.com> References: <10d162d5-2cd6-dd87-3289-a0187dfbf51f@daniel-mendler.de> <871r6sw9iz.fsf@gmail.com> <87a6lfnld0.fsf@gmail.com> <87eearulft.fsf@gmail.com> <871r6pr8bk.fsf@gmail.com> <54e4e409-5525-b796-9e9c-582735995cc1@yandex.ru> <87r1epp6h9.fsf@gmail.com> <266d8a54-90de-e904-f548-8ec29e52923c@yandex.ru> <87pmu8qu8s.fsf@gmail.com> <878s0vqgny.fsf@gmail.com> <54ad79de-d527-0462-edaa-eee56c724565@yandex.ru> <874kbjq88p.fsf@gmail.com> <09afb635-ca5d-cee5-2ea9-b119e2720cec@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Daniel Mendler , 48545@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 22 17:45:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mHpet-0007Hg-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 17:45:15 +0200 Original-Received: from localhost ([::1]:49560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mHper-0001PO-IZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Aug 2021 11:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mHpeg-0001PG-Nf for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mHpeg-0008WQ-GD for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mHpeg-0000ji-Dy for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2021 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Aug 2021 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48545 X-GNU-PR-Package: emacs Original-Received: via spool by 48545-submit@debbugs.gnu.org id=B48545.16296470672775 (code B ref 48545); Sun, 22 Aug 2021 15:45:02 +0000 Original-Received: (at 48545) by debbugs.gnu.org; 22 Aug 2021 15:44:27 +0000 Original-Received: from localhost ([127.0.0.1]:39717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHpe3-0000ie-Dv for submit@debbugs.gnu.org; Sun, 22 Aug 2021 11:44:27 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:39572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mHpdy-0000iO-Q8 for 48545@debbugs.gnu.org; Sun, 22 Aug 2021 11:44:23 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id z4so6621240wrr.6 for <48545@debbugs.gnu.org>; Sun, 22 Aug 2021 08:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=KOTlaTnmOE3pTDVHdkOT4vyqZyUvlGP2afQCOHnWDuM=; b=Rdy6006f8fzskQlUXFOXR+2kHHdRrVpVR7M5ALGuyCMMrckZoZSzsxpvmqxAp7wyuv ztpmUB+FX6MN67VfSV0fzYup/Io0dfRjukrJswlJ8Ovw7ke+8DfI7AG5WrtkPLp/1DyI 7iG288D/9MIAQUXLApeXOd9htgprjGDuht/2mbgrI3ewXz3LgR7PyQRoZ3UQtOdXWqcS 5IgcfpAHzEGwf3PirxkAvRCwwvwKChx131y5IjqDhGF+CFqx090ZCOu0AjW1GZUu69O9 NW8B8nTi9GRr5AVcLoE2j8Hb5EPgK+Otw2vj7rcihTkAsq4CnNxO5WMdSbz1ujJDEvVn jKPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=KOTlaTnmOE3pTDVHdkOT4vyqZyUvlGP2afQCOHnWDuM=; b=CHw9/CxtoqZaDDN+Zb/goiAxmGPkKnKlQjAhjSZ03mzs6BFDtVvUxsjIk2QhkJT3LG 04aHXddBsbE/hFayhmzq/gb7ijcxGy9wDsbDdxlui5LTEItNqlOWLeo+CvWIwc7kTr5H 7EcmraCINTieTS671ytwCXZsQUz7CH7Vvl8jOfF5B/xHW28VFZVY/qB7lNpbffVL0Emx bK75D4B1SJNlOc2Dtdj2Tjwqbof0kZDv72yit9NEf2hhm7AEknBX8JNCuMcbkXTKoy4V dPgZOvGWj9Ywy/kRPptvUZBcFvvqthCss6wIKd58I+VOs3xdlxzmgslfyXpn9OvZeFl0 hQzA== X-Gm-Message-State: AOAM533/NlD3iVX8WGTu5dUK2hz1Rvm76nAYlR9jbfNb2iL4q8Lith2k 34qjTW8Off3GwNlNxtgD4LIPw3e9W84= X-Google-Smtp-Source: ABdhPJz70Vfgh1UOMHHcEINoizPYYwi4a4FjBH2Eqqg6dGXPe6Dy9/RqRKOKg17PDgutG0bC+Vxlww== X-Received: by 2002:adf:fd8c:: with SMTP id d12mr5375564wrr.21.1629647052552; Sun, 22 Aug 2021 08:44:12 -0700 (PDT) Original-Received: from krug (a83-132-128-184.cpe.netcabo.pt. [83.132.128.184]) by smtp.gmail.com with ESMTPSA id y16sm6495961wmo.20.2021.08.22.08.44.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Aug 2021 08:44:11 -0700 (PDT) In-Reply-To: <09afb635-ca5d-cee5-2ea9-b119e2720cec@yandex.ru> (Dmitry Gutov's message of "Sun, 22 Aug 2021 16:52:02 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212424 Archived-At: Dmitry Gutov writes: > I don't think I'm obligated to support every trivial suggestion with a > patch and a benchmark. Of course you're not obliged to, but the fact that you won't code up your own "trivial suggestion" is eloquent. > Or explain, from various POVs, why removing the sorting step "because > it's expensive" is faulty reasoning. Could be, if it _were_ the reasoning. But it's not, as is quite easy to read here. > Or why the grouping approach in icomplete mode should match what the > default UI does and what other completion UIs (from which the grouping > feature was extracted) do as well. The sorting in the default completion UI is already discrepant to completions-all-sorted-completions, regardless of grouping. It's also quite slow, as reported. I doubt we want Icomplete to "match" that (not to mention the fact that Icomplete is a different type of UI). > Whatever, do what you like. I'm out of this thread. I've pushed ba852512f23fdab674086e35d4207e3970dd0912 to fix the described bugs and wrap this up. Left a TODO in minibuffer.el for anyone to experiment with "trivial suggestions" (or complex ones at that). Jo=C3=A3o