From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Daniel Mendler <mail@daniel-mendler.de>, 48545@debbugs.gnu.org
Subject: bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function`
Date: Sun, 22 Aug 2021 16:44:09 +0100 [thread overview]
Message-ID: <87o89peb7a.fsf@gmail.com> (raw)
In-Reply-To: <09afb635-ca5d-cee5-2ea9-b119e2720cec@yandex.ru> (Dmitry Gutov's message of "Sun, 22 Aug 2021 16:52:02 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> I don't think I'm obligated to support every trivial suggestion with a
> patch and a benchmark.
Of course you're not obliged to, but the fact that you won't code up
your own "trivial suggestion" is eloquent.
> Or explain, from various POVs, why removing the sorting step "because
> it's expensive" is faulty reasoning.
Could be, if it _were_ the reasoning. But it's not, as is quite easy to
read here.
> Or why the grouping approach in icomplete mode should match what the
> default UI does and what other completion UIs (from which the grouping
> feature was extracted) do as well.
The sorting in the default completion UI is already discrepant to
completions-all-sorted-completions, regardless of grouping. It's also
quite slow, as reported. I doubt we want Icomplete to "match" that (not
to mention the fact that Icomplete is a different type of UI).
> Whatever, do what you like. I'm out of this thread.
I've pushed ba852512f23fdab674086e35d4207e3970dd0912 to fix the
described bugs and wrap this up. Left a TODO in minibuffer.el for
anyone to experiment with "trivial suggestions" (or complex ones at
that).
João
next prev parent reply other threads:[~2021-08-22 15:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 18:56 bug#48545: 28.0.50; `icomplete-vertical-mode` does not support the `group-function` Daniel Mendler
2021-08-17 12:17 ` João Távora
2021-08-18 9:38 ` Kévin Le Gouguec
2021-08-18 9:55 ` João Távora
2021-08-19 11:18 ` João Távora
2021-08-19 12:38 ` Kévin Le Gouguec
2021-08-19 13:29 ` João Távora
2021-08-19 19:36 ` Kévin Le Gouguec
2021-08-19 15:02 ` Dmitry Gutov
2021-08-19 19:41 ` João Távora
2021-08-19 22:37 ` Dmitry Gutov
2021-08-19 23:39 ` João Távora
2021-08-19 23:51 ` Dmitry Gutov
2021-08-20 10:35 ` João Távora
2021-08-21 2:09 ` Dmitry Gutov
2021-08-21 9:40 ` João Távora
2021-08-21 12:01 ` Dmitry Gutov
2021-08-21 12:42 ` João Távora
2021-08-22 13:52 ` Dmitry Gutov
2021-08-22 15:44 ` João Távora [this message]
2021-08-21 0:24 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o89peb7a.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=48545@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=mail@daniel-mendler.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.