all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: display-supports-face-attributes-p question
Date: Sun, 29 Aug 2021 21:54:38 +0800	[thread overview]
Message-ID: <87o89g5pb5.fsf@yahoo.com> (raw)
In-Reply-To: <83pmtwlalq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Aug 2021 15:05:37 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> When the call to lookup_face in gui_supports_face_attributes_p gets
> into realize_gui_face, please show the results of
>
>   (gdb) pp attrs[LFACE_FONT_INDEX]
>
> before and after the call to font_load_for_lface in this snippet:
>
>       if (! FONT_OBJECT_P (attrs[LFACE_FONT_INDEX]))
> 	attrs[LFACE_FONT_INDEX]
> 	  = font_load_for_lface (f, attrs, Ffont_spec (0, NULL));

Before:
    #<font-spec nil haiku Noto\ Sans\ Mono nil iso8859-1 normal nil normal 12 nil 100 0 ((:user-spec . "monospace"))>

And after:
    #<font-object "-haiku-Noto Sans Mono-normal-normal-normal-*-12-*-*-*-m-0-iso8859-1">

I don't exactly understand what the code does, but that seems wrong.  I
think both the spec and the object should be italic?



  reply	other threads:[~2021-08-29 13:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87lf4kzkf7.fsf.ref@yahoo.com>
2021-08-29  9:09 ` display-supports-face-attributes-p question Po Lu
2021-08-29 10:58   ` Eli Zaretskii
2021-08-29 11:22     ` Po Lu
2021-08-29 12:05       ` Eli Zaretskii
2021-08-29 13:54         ` Po Lu [this message]
2021-08-29 14:30           ` Eli Zaretskii
2021-08-30  1:11             ` Po Lu
2021-08-30 11:47               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o89g5pb5.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.