From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 50340@debbugs.gnu.org
Subject: bug#50340: Fix remote-location in vc-git-log-incoming
Date: Fri, 03 Sep 2021 11:12:40 +0300 [thread overview]
Message-ID: <87o89aaxhj.fsf@mail.linkov.net> (raw)
In-Reply-To: <a113e085-a078-bd95-c8f0-13df3f1e82de@yandex.ru> (Dmitry Gutov's message of "Fri, 3 Sep 2021 02:29:52 +0300")
>> - (vc-git-command nil 0 nil "fetch")
>> + (vc-git-command nil 0 nil "fetch" (unless (string= remote-location "")
>> + remote-location))
>
> I'm not sure which scenario this fixes (pressing RET after 'C-u C-x v I'
> works fine here), but it shouldn't hurt either.
It fixes the scenario with a non-default remote. Could you try 'C-u C-x v I'
and typing the name of a non-default remote in a repo with two remotes?
I wonder if it already worked, and maybe I have some misconfiguration.
> So if you have a stable repro (some alternative completing-read-function?),
> you can go ahead and install.
Regarding the default completing-read-function, the prompt of 'C-u C-x v I'
doesn't provide completion on remote names. Maybe this should be improved
as well.
next prev parent reply other threads:[~2021-09-03 8:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 16:16 bug#50340: Fix remote-location in vc-git-log-incoming Juri Linkov
2021-09-02 23:29 ` Dmitry Gutov
2021-09-03 8:12 ` Juri Linkov [this message]
2021-09-04 1:50 ` Dmitry Gutov
2021-09-05 16:36 ` Juri Linkov
2021-09-05 19:28 ` Dmitry Gutov
2022-09-23 15:52 ` Juri Linkov
2022-10-02 18:35 ` Juri Linkov
2021-10-19 18:56 ` Lars Ingebrigtsen
2021-10-19 19:16 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o89aaxhj.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50340@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.