From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup? Date: Sun, 24 Oct 2021 14:17:15 +0200 Message-ID: <87o87ebos4.fsf@gnus.org> References: <87ilxqbmg7.fsf@miha-pc> <87sfwtcdg5.fsf@gnus.org> <87wnm49345.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19462"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: miha@kamnitnik.top, 51316@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 24 14:18:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mecSD-0004tP-8n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 14:18:21 +0200 Original-Received: from localhost ([::1]:52300 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mecSC-0000QA-1j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 24 Oct 2021 08:18:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39662) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mecRu-0000Pq-Gp for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 08:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54737) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mecRu-0007nt-8V for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 08:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mecRu-0006vq-4S for bug-gnu-emacs@gnu.org; Sun, 24 Oct 2021 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Oct 2021 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51316 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51316-submit@debbugs.gnu.org id=B51316.163507785226598 (code B ref 51316); Sun, 24 Oct 2021 12:18:02 +0000 Original-Received: (at 51316) by debbugs.gnu.org; 24 Oct 2021 12:17:32 +0000 Original-Received: from localhost ([127.0.0.1]:38047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mecRQ-0006uv-7E for submit@debbugs.gnu.org; Sun, 24 Oct 2021 08:17:32 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mecRN-0006ub-V7 for 51316@debbugs.gnu.org; Sun, 24 Oct 2021 08:17:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1gyaUVum2GRg2qBc/HoI/TQVAyCx3qHEbnjU1lod0uY=; b=RssSpmduDR3oMN8+9IAAFRTKM9 cVr8eKSQ5PtDdTDPRF0u4BMnkmuvC/mxSYa/2tg3GWbZBhlQz5a5HAGQ17+llfBi56Om/TcYAXMNu 6TNsq0mTe3pm/7bsmctinvmrBtLLLOmHfW5eQGKX0MVTBFHeOV+5xifDu3EbZCxKPQXc=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mecRD-0006ov-A8; Sun, 24 Oct 2021 14:17:22 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwCAAAAAByaaZbAAAAAXNSR0IArs4c6QAAAAJiS0dE AP+Hj8y/AAAACXBIWXMAAAsSAAALEgHS3X78AAAAB3RJTUUH5QoYDA8DQsvzUQAAAJhJREFUSMft k9ENgCAMRIGwkqPclF3KUfzBQC3aw/ihwX4R0tdryxHXMBZpMH9OIAeUk3BAXOqZQlqgIXBaQQF7 BjolyKFhLrRCCGKSRPNDa0WnJSgBsV2lXpWrgZyWrETml4R+Sx7Gb6lgiTEQGo3jw7nxwh9344tS UU3MKTSmJxXqQzw/tGgBFzDOcRUwChxjSvP9wEeBDeQcFNLrTcmuAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIxLTEwLTI0VDEyOjE1OjAyKzAwOjAwM7W0pAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0x MC0yNFQxMjoxNTowMiswMDowMELoDBgAAAA4dEVYdGljYzpjb3B5cmlnaHQAQ29weXJpZ2h0IChj KSAxOTk4IEhld2xldHQtUGFja2FyZCBDb21wYW55+Vd5NwAAACF0RVh0aWNjOmRlc2NyaXB0aW9u AHNSR0IgSUVDNjE5NjYtMi4xV63aRwAAACZ0RVh0aWNjOm1hbnVmYWN0dXJlcgBJRUMgaHR0cDov L3d3dy5pZWMuY2gcfwBMAAAAN3RFWHRpY2M6bW9kZWwASUVDIDYxOTY2LTIuMSBEZWZhdWx0IFJH QiBjb2xvdXIgc3BhY2UgLSBzUkdCRFNIqQAAAABJRU5ErkJggg== X-Now-Playing: Lost Girls's _Menneskekollektivet_: "Carried by Invisible Bodies" In-Reply-To: <87wnm49345.fsf@gnu.org> (Tassilo Horn's message of "Fri, 22 Oct 2021 22:45:23 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218096 Archived-At: Tassilo Horn writes: >> This is a feature request, in any case, so it should go to Emacs 29, I >> think. > > I would kindly ask to reconsider. This complete bug-reference > auto-setup thingy is new in emacs 28, the forge setup code is even just > a month old, and using your improved regexp doesn't seem risky at all > and might provide a much better user experience to possibly a lot of > users, my vote would be to fix this in emacs-28. But it's not a bug fix, and twiddling this may lead to introducing bugs. (All new features are nice to have.) Tassilo Horn writes: > With the reasoning above, I'd suggest using > > "[/:]\\([.A-Za-z0-9_/-]+?\\)\\(?:\\.git/?\\)?\\'" Doesn't match "https://github.com/emacs-mirror/emacs/", which is what this bug report was originally about, sort of. So I've now added a test for this and altered the regexp to pass the test (on the trunk). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no