all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: miha@kamnitnik.top, 51316@debbugs.gnu.org
Subject: bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup?
Date: Sun, 24 Oct 2021 14:17:15 +0200	[thread overview]
Message-ID: <87o87ebos4.fsf@gnus.org> (raw)
In-Reply-To: <87wnm49345.fsf@gnu.org> (Tassilo Horn's message of "Fri, 22 Oct 2021 22:45:23 +0200")

Tassilo Horn <tsdh@gnu.org> writes:

>> This is a feature request, in any case, so it should go to Emacs 29, I
>> think.
>
> I would kindly ask to reconsider.  This complete bug-reference
> auto-setup thingy is new in emacs 28, the forge setup code is even just
> a month old, and using your improved regexp doesn't seem risky at all
> and might provide a much better user experience to possibly a lot of
> users, my vote would be to fix this in emacs-28.

But it's not a bug fix, and twiddling this may lead to introducing bugs.
(All new features are nice to have.)

Tassilo Horn <thorn+gnu@fastmail.fm> writes:

> With the reasoning above, I'd suggest using
>
>   "[/:]\\([.A-Za-z0-9_/-]+?\\)\\(?:\\.git/?\\)?\\'"

Doesn't match "https://github.com/emacs-mirror/emacs/", which is what this
bug report was originally about, sort of.  So I've now added a test for
this and altered the regexp to pass the test (on the trunk).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2021-10-24 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 12:18 bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup? miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-22 14:59 ` Lars Ingebrigtsen
2021-10-22 20:45   ` Tassilo Horn
2021-10-22 21:42     ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23  9:12       ` Tassilo Horn
2021-10-23 12:58         ` Gregory Heytings
2021-10-24 12:17     ` Lars Ingebrigtsen [this message]
2021-10-26  9:01       ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 13:02         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o87ebos4.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=51316@debbugs.gnu.org \
    --cc=miha@kamnitnik.top \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.