From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#53638: [PATCH] newsticker better path handling and data storage Date: Mon, 31 Jan 2022 11:23:47 +0100 Message-ID: <87o83scifg.fsf@gmail.com> References: <87h79lgg5n.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31549"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mailj2@protonmail.com To: 53638@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 31 11:24:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nETrA-000853-Dc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 11:24:20 +0100 Original-Received: from localhost ([::1]:47852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nETr8-0001Lg-Qc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 31 Jan 2022 05:24:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50612) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nETqw-0001LK-GH for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 05:24:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45470) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nETqr-0006RT-OP for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 05:24:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nETqr-00046I-LH for bug-gnu-emacs@gnu.org; Mon, 31 Jan 2022 05:24:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 31 Jan 2022 10:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53638 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53638-submit@debbugs.gnu.org id=B53638.164362463615751 (code B ref 53638); Mon, 31 Jan 2022 10:24:01 +0000 Original-Received: (at 53638) by debbugs.gnu.org; 31 Jan 2022 10:23:56 +0000 Original-Received: from localhost ([127.0.0.1]:38373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nETqm-00045x-7s for submit@debbugs.gnu.org; Mon, 31 Jan 2022 05:23:56 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:37579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nETqk-00045l-MJ for 53638@debbugs.gnu.org; Mon, 31 Jan 2022 05:23:55 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id w11so24383706wra.4 for <53638@debbugs.gnu.org>; Mon, 31 Jan 2022 02:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=jfS2AZXvIKteU8iIp0Ja050QZNwoa5Srkfr7MpzpNsc=; b=fPGZLIasj5zRnT/niCtxeQeg+JW07BNv5yqV4xFB8hi3lvAvht/GQspiKtClm3Y0iz nV9L2dHhcqkO9nw565BXhct/FWsRCL+DZ2c+eajKxpCPqlIzur8+rdFndrFwaJad2BZc Rj6RucwRm1zaLXvK5RSZPLy3daYJX5xXzSI2x5ue9VtTz5QQ8W2VZxQp38x1Pslzm8Bw INeb7WIaZ3CHPv5IHgWNei9566to2tcPD2uptSFKxu3MGqg/73ldGLdEE7iYA2x7T831 7X5oc90obz3fbB1KRY+zNyq05fMo2O8Jklovp317Zsa8HDEGcbDy5fiKF2Bi+K2/91Oq jgFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=jfS2AZXvIKteU8iIp0Ja050QZNwoa5Srkfr7MpzpNsc=; b=17kw0ob4l9nrzNrbuZAHoVIo/buDiwAqFjcTQ0GuuyZZNSLj11dMM/G4ddKXTkevW4 YMg61DF0i3uC4xlbDIc2CkIXbLYOfXoWh95JL7MWRQ9X68YHp2RoSpQogVj7CA0oXOE+ 6rKe4d7fFBhMbNYK8szsDSYhAtqpI5KDo6S3o2QuE5U6Jc/mkNXMqwrDC9xkKG1s7tgt ks9mJ5+xaYpvxJsdBMfjmshiTcoFo16TbcfXTuijLP0eb3kKAM1utkte/YPyQ2tnVLd9 Jh8x3ynh4hWQ7mItz/dOTWjIirg8CikdlNPrz1nwGb3cn9P9vG9n2e9nVyNrLQ+yJ8/O Yw7g== X-Gm-Message-State: AOAM53391KDMEBBuo2MtqQZZ05qOX7LDVmDmr12W16UGugUJ4fgK9GTK HD5mN7Pwngqt67rznFU5mFY= X-Google-Smtp-Source: ABdhPJyUAqPf3QHB6l7gu92LckvR3j3U22zJiWUZ9IehOy/5o/qhX4V+qgdhEnmz8JV0II/vnKchTg== X-Received: by 2002:a05:6000:11cb:: with SMTP id i11mr16763248wrx.19.1643624628570; Mon, 31 Jan 2022 02:23:48 -0800 (PST) Original-Received: from rltb ([2a01:e0a:3f3:fb50:6309:eddd:6989:af26]) by smtp.gmail.com with ESMTPSA id g9sm6133243wri.95.2022.01.31.02.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 02:23:48 -0800 (PST) In-Reply-To: <87h79lgg5n.fsf@protonmail.com> (mailj's message of "Sun, 30 Jan 2022 19:47:03 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225660 Archived-At: >>>>> On Sun, 30 Jan 2022 19:47:03 +0000, mailj2--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" said: mailj2> The way newsticker currently handles paths involves directly concating mailj2> "/", which only works for UNIX systems. emacs-28 has `file-name-concat' for this very purpose, perhaps you could respin to use that instead. mailj2> Additionally, since newsticker uses `prin1-to-string' for storing mailj2> groups and cache, it should be enforced that `print-level' and mailj2> `print-length' are set to nil for the operation just as a precaution (it mailj2> happened to me that I manually set these once, which resulted in the mailj2> newsticker cache being corrupted). OK. It would be good to have a ChangeLog style commit message as well, see CONTRIBUTE for details. 'C-x 4 a' can help with writing it. Robert --