From: Robert Pluim <rpluim@gmail.com>
To: 53638@debbugs.gnu.org
Cc: mailj2@protonmail.com
Subject: bug#53638: [PATCH] newsticker better path handling and data storage
Date: Mon, 31 Jan 2022 11:23:47 +0100 [thread overview]
Message-ID: <87o83scifg.fsf@gmail.com> (raw)
In-Reply-To: <87h79lgg5n.fsf@protonmail.com> (mailj's message of "Sun, 30 Jan 2022 19:47:03 +0000")
>>>>> On Sun, 30 Jan 2022 19:47:03 +0000, mailj2--- via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
mailj2> The way newsticker currently handles paths involves directly concating
mailj2> "/", which only works for UNIX systems.
emacs-28 has `file-name-concat' for this very purpose, perhaps you
could respin to use that instead.
mailj2> Additionally, since newsticker uses `prin1-to-string' for storing
mailj2> groups and cache, it should be enforced that `print-level' and
mailj2> `print-length' are set to nil for the operation just as a precaution (it
mailj2> happened to me that I manually set these once, which resulted in the
mailj2> newsticker cache being corrupted).
OK. It would be good to have a ChangeLog style commit message as well,
see CONTRIBUTE for details. 'C-x 4 a' can help with writing it.
Robert
--
next prev parent reply other threads:[~2022-01-31 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 19:47 bug#53638: [PATCH] newsticker better path handling and data storage mailj2--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-31 10:23 ` Robert Pluim [this message]
2022-01-31 12:19 ` Eli Zaretskii
2022-01-31 15:47 ` Lars Ingebrigtsen
2022-01-31 20:09 ` mailj2--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-01 3:25 ` Eli Zaretskii
2022-05-16 3:50 ` bug#53638: [PATCH] newsticker better path handling and data Xavier Capaldi
2022-05-16 12:04 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o83scifg.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=53638@debbugs.gnu.org \
--cc=mailj2@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.