From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Mon, 14 Feb 2022 02:13:58 +0100 Message-ID: <87o83ab67d.fsf@web.de> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 14 02:15:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJPxX-00086U-IT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Feb 2022 02:15:19 +0100 Original-Received: from localhost ([::1]:50342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJPxW-0007la-1n for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Feb 2022 20:15:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59722) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJPxG-0007kt-Ac for bug-gnu-emacs@gnu.org; Sun, 13 Feb 2022 20:15:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45338) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJPxG-0002Es-04 for bug-gnu-emacs@gnu.org; Sun, 13 Feb 2022 20:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJPxF-00021g-P0 for bug-gnu-emacs@gnu.org; Sun, 13 Feb 2022 20:15:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Feb 2022 01:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.16448012587722 (code B ref 14013); Mon, 14 Feb 2022 01:15:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 14 Feb 2022 01:14:18 +0000 Original-Received: from localhost ([127.0.0.1]:39235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJPwY-00020U-Ic for submit@debbugs.gnu.org; Sun, 13 Feb 2022 20:14:18 -0500 Original-Received: from mout.web.de ([212.227.17.11]:37323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJPwT-000208-2L for 14013@debbugs.gnu.org; Sun, 13 Feb 2022 20:14:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1644801242; bh=VvBe0JCoI6Y6wZ+uWecCHl99kk+RbEkVCtWQHSa0Frc=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ioj+vwwRxdsbdBEJzAx5ycPPBKwmqax1GSm3ZXOIQbO+a1eWYwuo8iLN31n1WZEg4 +/flw1QOdjCLbTXxZDhqxVLvv3Yuk6Kogf34+NM/Oe1qL+CJQaI4Pf3EDm0dcqjae1 JMGHeKvAdhqpBqHieA6aH6GdOtTJ0ofFblq+GYJs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.60.174.212]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M1JEu-1nHlFD3T2o-002krE; Mon, 14 Feb 2022 02:14:01 +0100 In-Reply-To: <86zgmutwx9.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 13 Feb 2022 20:59:30 +0200") X-Provags-ID: V03:K1:0fhZM6aESlbsz3KfVB+nfV8nZ/FlX4t9Q1DxW0K9pzw9OatTLzi IEc8psRHMgfNxwQrNOd6bDsJ1OmoyAQpUZAfMdy6NYO3TW1xI3kxndr8rTWEgZEpPE5hnds tnhTntXluiRzq52j+3HUTPqjBaIU7EtMz+uVBxwXRVsXbGCa+L2DZRwdTLf41HesaojMg1d hqxsDSnCDZmRrIds9yWTQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:JBqwCvGVPFM=:Yi8iDApHRHA9BmCxDUk12q xWM+/pxPMIYHTK29QQa/ZZembX/152ybxtuNeEIWkPYou8SNNVUfl6bScoG7XBoahfSF9+akU 3VNqXtoHlcINGJTP8j+/7fsR5aVEVMcuMiaui/i1XVfye7Rgl83TH0WKYVY9aMaoLV9OyL2C5 SimmMsUAo0mOir69CH/iY2vKYYQdwUgUk8DOdscU1o0JX2sG+KfBrZvLjrQkFLxVQoSRo9f58 SzbGwK6X3m9hZ79QoFl0r3XHFDNJNMMmubP8mltd5dDMOKfrqliMvlwKOrvavZ34GE9bRdXi5 /8ttHi02hTd5Ivwxj0uWr9ceXeULg47sh9SLyX8xnfmK1aA88d+6uq4SHrq+1gKaYMNKcOE/D Q0f+FnOE73QhoY6ujKnIJz32nxGIf7HhIxfGkBDfJdIYDTUKuzpgMU0+R4EJtyLlZwRr+b8Es iTQc7xeBMk6OjDzrFdkoqgmQVPiD2LshOSKku2rOgHxD3iXbJl58uR+xW5/G01pmYWKKb0dOv PUvuQYbZmYF+ZXUuZxgJgnN4vdstTblnUBF8OCe+3U+f9BQ1ZQMMsE9rDOODPankir5ISnjtC SstfRdAHZLaOtrEE0WBBmwLHiXwofo7HJGXvsgcckQ5lQx9fo40Qs33BQneU2iiGY1RtkkBf5 AmuGyh1RDHME565PHSeYPIYmPfUJZjXGEgrnfMc7i5EOilFAKJpFXe5Q1HcvVK2PuwnFOhih1 0c9NSew7bZfCOw6MkzCTr2YnnyZPIfZr1xTG+HL6n4u2auNtQHMIxrOAS3ud4U75W0scpbdV X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226848 Archived-At: Juri Linkov writes: > After a short delay, this has been implemented now: Thanks. I quickly tested your patch, and it seems to work well so far (except for the ^ thing fo course). Also highlighting worked. Anything particular I should keep my eye on? I only noticed that if we keep the patch, the docstrings of the touched functions seem to need and update. > (defun wdired-change-to-wdired-mode () > @@ -238,8 +239,9 @@ wdired-change-to-wdired-mode > (setq-local wdired--old-point (point)) > (wdired--set-permission-bounds) > (setq-local query-replace-skip-read-only t) > - (add-function :after-while (local 'isearch-filter-predicate) > - #'wdired-isearch-filter-read-only) > + (add-function :around (local 'isearch-search-fun-function) > + #'dired-isearch-search-filenames) > + (setq-local replace-re-search-function #'dired-isearch-search-filenames) And: Is it intended that this is unconditional (I would expect a `dired-isearch-filenames-mode' test)? Thanks, Michael.