From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Mon, 28 Feb 2022 10:38:31 +0100 Message-ID: <87o82rqqjs.fsf@gnus.org> References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="858"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54190@debbugs.gnu.org, Stefan Monnier To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 10:39:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOcVC-000AZU-FY for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 10:39:34 +0100 Original-Received: from localhost ([::1]:59512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOcVB-0003pX-3m for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 04:39:33 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOcUh-0003on-BB for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 04:39:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37929) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOcUg-0001vy-Ej for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 04:39:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOcUg-0005Iz-7i for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 04:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.164604112320366 (code B ref 54190); Mon, 28 Feb 2022 09:39:02 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 28 Feb 2022 09:38:43 +0000 Original-Received: from localhost ([127.0.0.1]:60059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOcUN-0005IP-82 for submit@debbugs.gnu.org; Mon, 28 Feb 2022 04:38:43 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:34546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOcUL-0005IB-JV for 54190@debbugs.gnu.org; Mon, 28 Feb 2022 04:38:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GBrfacDkpbCi3fOTtfMQEO9Gjbo0AwTG7/R9ZU8TaqE=; b=vEnBN4CrD0dCS5T0++cP23khXn Sw5IPSk+/skW7FtVM0XgxdNKorbktuami2rf+7gyvdLKYOF2QtG/Q5a7ZZ/iWa+0yagy/cYlkjBdS r/KkmkWP0FogPl68E7xNyNkr7Oh3mcz0aVCjRf+uSBd9w9FfmiK08mRKIxCv3vscj4DU=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOcUB-0005t7-Rs; Mon, 28 Feb 2022 10:38:34 +0100 X-Now-Playing: Xiu Xiu's _The Passenger_: "Ian Curtis Wish List SOLO" In-Reply-To: <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> (Jim Porter's message of "Mon, 28 Feb 2022 00:16:21 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227768 Archived-At: Jim Porter writes: > Ok, the breaking commit is b03f74e0f2a578b1580e8b1c368665850ee7f808 > ("Don't quote lambdas in several places"). Reverting the change in > that commit in lisp/eshell/esh-var.el fixes things, although I'm not > sure why yet. I believe that code gets evaluated by `eshell-do-eval', > which evaluates things in a very particular way in order to support > deferring evaluation at various points. Once I'm sure I understand why > this is breaking, I'll post a patch to fix the bustage. It's this bit? Hm... diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el index 96838d4132..7388279f15 100644 --- a/lisp/eshell/esh-var.el +++ b/lisp/eshell/esh-var.el @@ -463,8 +463,8 @@ eshell-parse-variable-ref (eshell-as-subcommand ,(eshell-parse-command cmd)) (ignore (nconc eshell-this-command-hook - (list (function (lambda () - (delete-file ,temp)))))) + (list (lambda () + (delete-file ,temp))))) (quote ,temp))) (goto-char (1+ end))))))) ((eq (char-after) ?\() Trying to follow the logic of how this is eventually evaluated isn't, er, obvious, but I'm not sure how that change could break anything, either. Perhaps Stefan has a comment; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no