From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54225: [PATCH] with-demoted-errors: Fix macroexp-warn-and-return call Date: Thu, 03 Mar 2022 15:36:09 +0100 Message-ID: <87o82nhzmu.fsf@gnus.org> References: <20220303030035.570230-1-kyle@kyleam.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12784"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54225@debbugs.gnu.org, Stefan Monnier , lomov.vl@yandex.ru To: Kyle Meyer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 03 15:40:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPmcc-000372-Gq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Mar 2022 15:40:02 +0100 Original-Received: from localhost ([::1]:55290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nPmcb-0007Fv-6z for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Mar 2022 09:40:01 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nPmZj-000308-G1 for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 09:37:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nPmZj-0003CQ-6W for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 09:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nPmZj-0007sC-1Q for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2022 09:37:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Mar 2022 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54225-submit@debbugs.gnu.org id=B54225.164631818330162 (code B ref 54225); Thu, 03 Mar 2022 14:37:02 +0000 Original-Received: (at 54225) by debbugs.gnu.org; 3 Mar 2022 14:36:23 +0000 Original-Received: from localhost ([127.0.0.1]:41980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZ5-0007qQ-5G for submit@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:23 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:41938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nPmZ3-0007qC-2o for 54225@debbugs.gnu.org; Thu, 03 Mar 2022 09:36:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=FaQ9AE8W1CmrOLYLjZ5GneG7KeYk3hghBL86EweBlgw=; b=TtHzgitar3MilqZwO9Wp0KFL6S oCctL6Rek/lb39RtaAeB/V68OlhBg/pNwaJ/PD+/VOGSTmrp5BztS6VRW7eLPlNYp+7IZW3QgDBYG XsLSTlSTuA9aXeBpjNRMh1EDxcAnsWIQakdbDbS4u1dfnC12V5AdHttsS2LWZrXZK3Cg=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nPmYr-0000t5-IS; Thu, 03 Mar 2022 15:36:11 +0100 X-Now-Playing: Twinkle3's _Minor Planets_: "Ryugu 162173" In-Reply-To: <20220303030035.570230-1-kyle@kyleam.com> (Kyle Meyer's message of "Wed, 2 Mar 2022 22:00:35 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227940 Archived-At: Kyle Meyer writes: > The macroexp-warn-and-return call added to with-demoted-errors in > d52c929e31f (2022-02-04) is incorrect. The with-demoted-errors format > string is passed as MSG, the actual message is passed as FORM, and the > form is passed as CATEGORY, leading to with-demoted-errors returning > "Missing format argument". > > * lisp/subr.el (with-demoted-errors): Call macroexp-warn-and-return > with correct arguments. [...] > - (macroexp-warn-and-return format "Missing format argument" exp)))) > + (macroexp-warn-and-return "Missing format argument" exp)))) The code flow in with-demoted-errors is pretty confusing. Can it be improved upon instead of tweaked this way? (`format' here will be "Error: %S" at least in some cases, I guess?) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no