From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Alexander Adolf <alexander.adolf@condition-alpha.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] EUDC email addresses via completion-at-point in message-mode
Date: Wed, 13 Apr 2022 18:44:38 -0700 [thread overview]
Message-ID: <87o814wi9l.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <ea2bb7e91bee666649cc152abbe9312a@condition-alpha.com> (Alexander Adolf's message of "Sat, 09 Apr 2022 18:24:02 +0200")
Alexander Adolf <alexander.adolf@condition-alpha.com> writes:
> Hello,
>
> when switching to a new in-buffer completion user interface package
> which is solely based on completion-at-point, I observed that email
> address completion in message-mode happens in the minibuffer, regardless
> of what UI on top of completion-at-point I use. Also, EUDC's ability to
> aggregate search results from several servers, which was recently added
> with commit 0470a4a939772c4bd25123b15f5eadab41f8bee5, was not kicking
> in, i.e. I was presented results from a single EUDC server only.
>
> Browsing through message.el quickly brought me to the sixth of the 21
> FIXMEs in that file, which reads on line 3183:
>
> ;; FIXME: merge the completion tables from ecomplete/bbdb/...?
> ;;(add-hook 'completion-at-point-functions #'message-ecomplete-capf nil t)
> (add-hook 'completion-at-point-functions #'message-completion-function nil t)
>
> Thus, the most straightforward solution to my problem seemed to make a
> new EUDC function that can be added to completion-at-point-functions,
> and to update message-mode to actually add that function to
> completion-at-point-functions. This is what the below attached patch
> does.
Thank you for working on this! I think everyone can agree that the
current setup is tricky to work within. As the author of (yet another)
contact management package, I do what I assume anyone else would do:
clobber the binding of TAB altogether.
I understand that EUDC has the capability of combining results from
multiple backends, but completion-at-point also has those capabilities,
and personally I would much prefer to see message-mode make use of one
of completion-table combining functions. Better to be wrapped inside one
burrito than two!
The `message-tab' would still need to check where it's been called and
make a decision before calling `completion-at-point', but it seems much
cleaner for each package to provide a function that's suitable for use
in a combined capf completion table, rather than writing an adapter for
EUDC.
What do you think?
Eric
next prev parent reply other threads:[~2022-04-14 1:44 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 16:24 [PATCH] EUDC email addresses via completion-at-point in message-mode Alexander Adolf
2022-04-12 21:12 ` Thomas Fitzsimmons
2022-04-13 14:44 ` Alexander Adolf
2022-04-14 0:26 ` Thomas Fitzsimmons
2022-04-15 21:23 ` Alexander Adolf
2022-04-14 13:02 ` Eric S Fraga
2022-04-14 13:27 ` Thomas Fitzsimmons
2022-04-14 13:52 ` Eric S Fraga
2022-04-15 21:39 ` Alexander Adolf
2022-04-17 12:12 ` Eric S Fraga
2022-04-15 21:35 ` Alexander Adolf
2022-04-17 12:20 ` Eric S Fraga
2022-04-17 13:58 ` Thomas Fitzsimmons
2022-04-17 17:21 ` Eric S Fraga
2022-04-14 14:02 ` Stefan Monnier
2022-04-15 21:58 ` Alexander Adolf
2022-04-15 22:57 ` Eric Abrahamsen
2022-04-14 1:44 ` Eric Abrahamsen [this message]
2022-04-14 13:04 ` Eric S Fraga
2022-04-14 15:17 ` Eric Abrahamsen
2022-04-14 15:26 ` Stefan Monnier
2022-04-15 16:31 ` Eric Abrahamsen
2022-04-15 17:17 ` Stefan Monnier
2022-04-15 22:30 ` Alexander Adolf
2022-04-15 22:16 ` Alexander Adolf
2022-04-15 22:58 ` Stefan Monnier
2022-04-26 14:39 ` Alexander Adolf
2022-04-26 18:58 ` Filipp Gunbin
2022-04-28 17:15 ` Alexander Adolf
2022-04-29 14:43 ` Thomas Fitzsimmons
2022-05-02 17:10 ` Alexander Adolf
2022-05-03 18:03 ` Thomas Fitzsimmons
2022-05-05 16:32 ` Alexander Adolf
2022-05-05 16:57 ` Thomas Fitzsimmons
2022-05-10 21:16 ` Thomas Fitzsimmons
2022-05-16 12:35 ` Alexander Adolf
2022-04-29 23:04 ` Filipp Gunbin
2022-05-02 21:38 ` Alexander Adolf
2022-05-02 22:32 ` Filipp Gunbin
2022-05-03 16:18 ` Alexander Adolf
2022-05-03 16:22 ` Alexander Adolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o814wi9l.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=alexander.adolf@condition-alpha.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.