bug#48598: 28.0.50; buffer-naming collisions involving bouncers in ERC

[Michael Albinus <michael.albinus@gmx.de>]

"J.P." <jp@neverwas.me> writes:

Hi,

> On a tenuously related note, for some reason, I'm unable to run
>
>   make -C test -j<NN> check-lisp-erc ...
>
> without incurring a "'warning: jobserver unavailable: using -j1". Plain
> old -j without the <NN> works fine, and other targets I've tried, like
> check and check-expensive, seem unaffected.

In test/infra/gitlab-ci.yml there is the comment

--8<---------------cut here---------------start------------->8---
    # TODO: with make -j4 several of the tests were failing, for
    # example shadowfile-tests, but passed without it.
--8<---------------cut here---------------end--------------->8---

I've never investigated what's up.

> FWIW, the course of action prescribed by the info node "(make) Error
> Messages", namely, prepending a "+", seems to remedy the problem.
>
>   diff --git a/test/Makefile.in b/test/Makefile.in
>   index 3b6e116e65..c0256d770d 100644
>   --- a/test/Makefile.in
>   +++ b/test/Makefile.in
>   @@ -247,7 +247,7 @@ define subdir_template
>      SUBDIR_TARGETS += check-$(subst /,-,$(1))
>      .PHONY: check-$(subst /,-,$(1))
>      check-$(subst /,-,$(1)):
>   -       @${MAKE} check LOGFILES="$(patsubst %.el,%.log, \
>   +       +@${MAKE} check LOGFILES="$(patsubst %.el,%.log, \
>                   $(patsubst $(srcdir)/%,%,$(wildcard ${srcdir}/$(1)/*.el)))"
>    endef

If this fixes the problem, pls push the patch. And change the files
under test/infra/ accordingly, please.

Best regards, Michael.