all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Emanuel Berg via Users list for the GNU Emacs text editor <help-gnu-emacs@gnu.org>
To: help-gnu-emacs@gnu.org
Subject: Re: EWW func add url under point as bookmark
Date: Tue, 19 Apr 2022 02:24:07 +0200	[thread overview]
Message-ID: <87o80xc448.fsf@zoho.eu> (raw)
In-Reply-To: 87ilr6oxa7.fsf@gnu.org

Alex wrote:

> PD: nice website Emanuel

PD? thanks :)

> Ok, now, Im browsing in EWW, and Im in a page with many
> interesting urls, I want bookmarks all urls after point.

Uhm, when you say URL, you mean hyperlink?

> But moving the cursor, M-x eww-bookmark-add RET <title> RET
> with all urls is painfull.
>
> I need a func!
>
> #+begin_src elisp
>
> ;; Copyright 2022 Alex
> ;; under GPLv3-or-later License
>
> (defun eww-bookmark-buffer-urls ()
>   "Bookmark urls in current buffer"

That's (to the) right, period.

>   (interactive)
>   (shr-next-link)
>   (let ((url-str (thing-at-point 'url)))

I still think it better to check for nil here.

>   (if (save-excursion (shr-next-link))
>       (eww-bookmark-buffer-urls)))

Hm, that's look sa bit weird ... instead drop recursion and
when you find what you are looking for, just get it and
go on. (Should be `when' BTW as it stands.)

> Works, but sadly stop when find an url already bookmarked :/

Sadly, you checked this in the other code and it is signalled
as an error if it happens, sounds like overkill indeed..

-- 
underground experts united
https://dataswamp.org/~incal




  reply	other threads:[~2022-04-19  0:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 19:25 EWW func add url under point as bookmark Alex
2022-04-14 20:08 ` [External] : " Drew Adams
2022-04-14 23:31   ` Michael Heerdegen
2022-04-14 21:08 ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-15 13:40 ` Alex
2022-04-15 14:17   ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-16 14:34     ` Alex
2022-04-16 18:51       ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-18 20:29         ` Alex
2022-04-18 20:47           ` Emanuel Berg via Users list for the GNU Emacs text editor
2022-04-18 22:13             ` Alex
2022-04-19  0:24               ` Emanuel Berg via Users list for the GNU Emacs text editor [this message]
2022-04-16 19:12       ` Emanuel Berg via Users list for the GNU Emacs text editor
     [not found] ` <87ee1z8jap.fsf@zoho.eu>
     [not found]   ` <CAJcAo8v7+CYd03EyFi_oK+E8crS+9gLea0jBqziN9wPMvGvvrQ@mail.gmail.com>
2022-04-17  0:16     ` [emacs-w3m:13862] " Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o80xc448.fsf@zoho.eu \
    --to=help-gnu-emacs@gnu.org \
    --cc=moasenwood@zoho.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.