From: Ihor Radchenko <yantar92@gmail.com>
To: "N. Jackson" <nljlistbox2@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Off-by-one error in width of Agenda window?
Date: Wed, 20 Apr 2022 12:01:49 +0800 [thread overview]
Message-ID: <87o80wz9le.fsf@localhost> (raw)
In-Reply-To: <87czhdqi9p.fsf_-_@moondust.localdomain>
"N. Jackson" <nljlistbox2@gmail.com> writes:
> It turns out there is already an Emacs bug for this (Bug 19395:
> Setting left fringe to 0 messes up window-width
> (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19395)).
>
> My understanding of the discussion is that the bug is caused by
> window-width including in its return value the width of the column
> reserved for the continuation glyph (which column exists when one or
> both of the fringes is/are turned off), so window-width over-reports
> the available width of the window in this case.
Thanks a lot for the detailed analysis!
> The bug hasn't been closed, but IIUC it has been "fixed" by changing
> the documentation of window-width to indicate the limitation. The
> latter part of the bug thread is a discussion and development of the
> function window-max-chars-per-line.
>
> It seems that Org maybe should be using window-max-chars-per-line
> rather than window-width.
>
> [Unfortunately w-m-c-p-l is not a drop in replacement for
> window-width; it doesn't just fix the continuation glyph column
> "bug", but it also adds additional functionality and has a different
> signature.]
Could you elaborate why window-max-chars-per-line cannot be used instead
of window-width by Org? It appears to be strictly more accurate.
Best,
Ihor
next prev parent reply other threads:[~2022-04-20 4:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 13:10 [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] N. Jackson
2022-04-18 13:39 ` Ihor Radchenko
2022-04-18 19:06 ` N. Jackson
2022-04-19 3:16 ` Ihor Radchenko
2022-04-19 14:06 ` [BUG] Off-by-one error in width of Agenda window? N. Jackson
2022-04-20 4:01 ` Ihor Radchenko [this message]
2022-04-20 10:07 ` N. Jackson
2022-04-21 5:25 ` [PATCH] org-agenda: Use `window-max-chars-per-line' instead of `window-width' Ihor Radchenko
2022-04-21 7:16 ` N. Jackson
2022-04-21 7:56 ` N. Jackson
2022-04-22 5:58 ` [PATCH v2] org-agenda: Use `window-max-chars-per-line' to calculate max text width Ihor Radchenko
2022-04-22 8:42 ` N. Jackson
2022-04-22 9:27 ` Ihor Radchenko
2022-04-22 15:46 ` N. Jackson
2022-04-24 7:04 ` Ihor Radchenko
2022-04-24 11:55 ` Thank you " N. Jackson
2022-04-18 14:30 ` [BUG] Off-by-one error in width of Agenda window? [9.5.2 (release_9.5.2-25-gaf6f12 @ /data/installs/snapshots/emacs-28.1/lisp/org/)] Tory S. Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o80wz9le.fsf@localhost \
--to=yantar92@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=nljlistbox2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.