From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55208: 29.0.50; MS-Windows GUI selection dialogs and double-buffering Date: Sun, 08 May 2022 13:33:40 +0800 Message-ID: <87o808611n.fsf@yahoo.com> References: <83mtg15jg9.fsf@gnu.org> <87levkpwma.fsf@yahoo.com> <83czgpzt7n.fsf@gnu.org> <87tua17npc.fsf@yahoo.com> <838rrdzpdz.fsf@gnu.org> <87pmkp7l9l.fsf@yahoo.com> <834k21zmfc.fsf@gnu.org> <87levd7ib5.fsf@yahoo.com> <83zgjty68z.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6704"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: 55208@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 08 07:34:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nnZYj-0001cB-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 May 2022 07:34:21 +0200 Original-Received: from localhost ([::1]:39972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nnZYi-0005Pi-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 May 2022 01:34:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nnZYQ-0005PL-8z for bug-gnu-emacs@gnu.org; Sun, 08 May 2022 01:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59377) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nnZYP-0000gk-Vi for bug-gnu-emacs@gnu.org; Sun, 08 May 2022 01:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nnZYP-0001kQ-Ns for bug-gnu-emacs@gnu.org; Sun, 08 May 2022 01:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2022 05:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55208 X-GNU-PR-Package: emacs Original-Received: via spool by 55208-submit@debbugs.gnu.org id=B55208.16519880386708 (code B ref 55208); Sun, 08 May 2022 05:34:01 +0000 Original-Received: (at 55208) by debbugs.gnu.org; 8 May 2022 05:33:58 +0000 Original-Received: from localhost ([127.0.0.1]:53274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnZYL-0001k8-TN for submit@debbugs.gnu.org; Sun, 08 May 2022 01:33:58 -0400 Original-Received: from sonic301-30.consmr.mail.ne1.yahoo.com ([66.163.184.199]:43378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nnZYL-0001jw-23 for 55208@debbugs.gnu.org; Sun, 08 May 2022 01:33:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651988031; bh=hBYcLEgaIPqs1ZU1N5IccfUT+X39lsTQF6XDp3N+sK8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=PkK/9d7gl8fgeOGJ020TSdcIw7hCRf46eClTdCZVHNeYpbNBrTIeO7LsKwRVExsCALVQjkcunvexiqaRZ6xMnKqlpNPlPBzl7fBKdgHI6KNiD1Uo9GpyugsSVr/5o6tK9Rk9+4qpPEE1hlJ1K4ZSq7sqt9DCkvPaantPUXimJR+suq3OHQx7N8i0/ajWCXU4IalTLeoaaWheUqsgLM4qLRwA5zmUe5XjyFkV3M1V7Qo6hT1qqOAjzQ9v3btHvlIKYzDq60nF5/VGB4fkRYguEqaGgHIocndz9pxMAO7+XW5HkCkVSWVa5YUzmEEiIWCrEUM3Kxb7chrLc4qz87Xj3w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1651988031; bh=ASuGLT7BU5OjziFbU66CY6XvLYWsjqdmVRZdz3J8Ek2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Zul4oE+YCjgsprqP4En/Pc7WOMoUieIc+sDHay9JdI2UUQlvhJRtVHV7KT678CJjQhG7majY+74ioaPjm5YYbHcPNJYt+3zdwArOO123IGE8f91sq2u1WCxhqqBYF/ZvFHoVI/URmMQTJxTT2eeARPeL2CpSCdGttjc1liyt++T1htX/jWtCdW5hCXRi0YTwLr9xRkTJFsDkI68zkSasMDZiIbTin7lfcaYCcYFhwMQcNo8AaozrZOaLHQnT5r9CdSHm3iyFv/h5F3a/jqrBEkKUUqTDAQpe/Hi0VsrcdEvJtzXWNX7RqLepOK47e0T6+Q8pcxkNJtErmg6LuU656Q== X-YMail-OSG: nb7odXQVM1mI5_IKWNpZnoz51Rea6JkUMd8198zhzPdqh84MyGXKcXeYINUs9Z1 eWHtCKhb2i86UoLlZCbLkENq3ftLa7hKPGIwDzUol4BxhjYO1uE8F_i5r.aLVPh_lVG3pfdG2Blr dcKcza7oGLL_QG.neSCA8RjaBfOymwc1NFE.waYYZI7I9ZP6XMXFKvZkNcYd4Sr.HnmFFbZGflje L198hWap8J4y8ssfrqEYgl1iEylT.1K1Jzy86.on447ceMoNcPmaqZCRlc13_FbjXwm6E.BANttP QKVbmz2nFTGWpot2zQ8UrvRiGEd7TelkJF5.LRDPn0ijHObenb5hzhuAyKDPA6YvKi1UPiD.7kKL b49sEEG3Nh_jG.dMU03Z4pME3.8KTZSRkSuiZnjEw4ptsGKA8Jabqt0Hs4g.6aCSidvAZLYbawuS LG0fZop6EUtly5Ux0zMNqaWvy2dwA5EX8JM3LsogHUJMFEhyvU7vvT_MbeVPY6.v8d8YFcaaqRpp 19PdkGnX_3LeeFld.EEcw2Udqd6xkoplpw2mimUG13tEO4nh0gPoHMSCjdLA_WxmFqk_sO.avVBP A_fhdekhGa5u08RyED0zFGrhm.KKqTw1DOi5O8HpSSm.YAy3ge9i3ldVKXKWVqgLQyLj37_HACeb GGIPNk.gwK0mUjFEm0ekYa8GGBe2.Ex5JDJTJ.35vVgInBletOh9mJjx.zZ2fC8ANS5G02MjytUV L8S3L.vBm.eUhgKzRqYJaZDLD4j7l0UhXQtnRxZ34vajm4mUD8BqKuyYbO9Bgg2Zt7WcUxpjIlbB QYUpqSoRx.wP6whf.ax3tYewFtpjIPEtjwl9D09gia X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sun, 8 May 2022 05:33:51 +0000 Original-Received: by hermes--canary-production-sg3-795d7b4d54-tjk4t (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7e05faecc57345fd5713c10b51335763; Sun, 08 May 2022 05:33:44 +0000 (UTC) In-Reply-To: <83zgjty68z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 May 2022 13:41:32 +0300") X-Mailer: WebService/1.1.20188 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231623 Archived-At: Eli Zaretskii writes: > diff --git a/src/w32fns.c b/src/w32fns.c > index 0f25c1a..e5becb5 100644 > --- a/src/w32fns.c > +++ b/src/w32fns.c > @@ -247,6 +247,8 @@ #define MENU_FREE_DELAY 1000 > > static int w32_unicode_gui; > > +static bool w32_selection_dialog_open; > + > /* From w32menu.c */ > int menubar_in_use = 0; > > @@ -4184,6 +4186,16 @@ w32_wnd_proc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > update_rect.left, update_rect.top, > update_rect.right, update_rect.bottom)); > #endif > + /* Under double-buffering, update the frame from the back > + buffer, to prevent a "ghost" of the selection dialog to > + be left on display while the user selects in the dialog. */ > + if (w32_selection_dialog_open > + && !w32_disable_double_buffering > + && FRAME_OUTPUT_DATA (f)->paint_dc) > + BitBlt (FRAME_OUTPUT_DATA (f)->paint_buffer_handle, > + 0, 0, FRAME_PIXEL_WIDTH (f), FRAME_PIXEL_HEIGHT (f), > + FRAME_OUTPUT_DATA (f)->paint_dc, 0, 0, SRCCOPY); > + > EndPaint (hwnd, &paintStruct); > leave_crit (); > > @@ -7755,6 +7767,15 @@ w32_dialog_in_progress (Lisp_Object in_progress) > { > Lisp_Object frames, frame; > > + /* Indicate to w32_wnd_proc that the selection dialog is about to be > + open (or was closed, if IN_PROGRESS is nil). */ > + if (!w32_disable_double_buffering) > + { > + enter_crit (); > + w32_selection_dialog_open = !NILP (in_progress); > + leave_crit (); > + } > + > /* Don't let frames in `above' z-group obscure dialog windows. */ > FOR_EACH_FRAME (frames, frame) > { This seems to work fine, please go ahead and install it. Thanks.