bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

[Robin Putters]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

On MS Windows systems, where the Emacs executable is typically not in the PATH, creating the async sub processes for the native compiler will fail because they are started in a random working directory. The included patch will inherit the working directory from the parent emacs process by setting default-directory before creating the sub process.    

Robin Putters

[-- Attachment #2: Pat2409.diff --]
[-- Type: application/octet-stream, Size: 625 bytes --]

 lisp/emacs-lisp/comp.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index a363bed..61968f4 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -3961,6 +3961,7 @@ display a message."
                         (comp-log "\n")
                         (mapc #'comp-log expr-strings)))
                    (load1 load)
+                   (default-directory invocation-directory)
                    (process (make-process
                              :name (concat "Compiling: " source-file)
                              :buffer (with-current-buffer

bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

[Eli Zaretskii]

> From: Robin Putters <robin.putters@keronic.com>
> Date: Thu, 7 Apr 2022 14:35:57 +0000
> 
> On MS Windows systems, where the Emacs executable is typically not in the PATH, creating the async sub processes for the native compiler will fail because they are started in a random working directory. The included patch will inherit the working directory from the parent emacs process by setting default-directory before creating the sub process.    

Please tell more about the failure and its reasons.  The compilation
command does this:

                   (process (make-process
                             :name (concat "Compiling: " source-file)
                             :buffer (with-current-buffer
                                         (get-buffer-create
                                          comp-async-buffer-name)
                                       (setf buffer-read-only t)
			               (current-buffer))
                             :command (list
                                       (expand-file-name invocation-name
                                                         invocation-directory)
                                       "--batch" "-l" temp-file)

So the program we invoked already has its executable file name
expanded relative to invocation-directory, and we shouldn't need PATH
at all.  What am I missing?

bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> So the program we invoked already has its executable file name
> expanded relative to invocation-directory, and we shouldn't need PATH
> at all.  What am I missing?

I don't understand either -- using nativecomp Emacs without having the
Emacs executable in PATH works just fine for me.

Robin, what was the actual error messages you were seeing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54766: [PATCH] 28.1.0; Native comp: Inherit working directory for sub processes (MS Windows)

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I don't understand either -- using nativecomp Emacs without having the
> Emacs executable in PATH works just fine for me.
>
> Robin, what was the actual error messages you were seeing?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no