From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56329: 29.0.50; [PATCH] RET at EOB of *Server* (gnus) Date: Fri, 01 Jul 2022 12:48:22 +0200 Message-ID: <87o7y9az2h.fsf@gnus.org> References: <87o7y96ezm.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11017"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56329@debbugs.gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 01 12:51:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7EFj-0002d0-UE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jul 2022 12:51:59 +0200 Original-Received: from localhost ([::1]:47916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o7EFi-0000XB-RO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Jul 2022 06:51:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46150) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o7ECs-0005pn-5u for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 06:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o7ECr-0003mx-T6 for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 06:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o7ECr-0005N3-PS for bug-gnu-emacs@gnu.org; Fri, 01 Jul 2022 06:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Jul 2022 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56329-submit@debbugs.gnu.org id=B56329.165667252020590 (code B ref 56329); Fri, 01 Jul 2022 10:49:01 +0000 Original-Received: (at 56329) by debbugs.gnu.org; 1 Jul 2022 10:48:40 +0000 Original-Received: from localhost ([127.0.0.1]:36337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7ECV-0005Lx-Nt for submit@debbugs.gnu.org; Fri, 01 Jul 2022 06:48:39 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o7ECR-0005Le-9Y for 56329@debbugs.gnu.org; Fri, 01 Jul 2022 06:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CNU/4MVdeyZWjyC4HK5+eL3VPU3jtSvEjQ7iW0Oq9w4=; b=NiW6093amQ/UOTddyI/8C8yQI2 7qcx1n2NNtpPZekBnN8uqz7qhyyxjw/47kMXJ8BoNG0Yfh59/l+LIR5Mcm3WbAtzzo7Tokmfo/vRb l1nKnJR+6tedXXaaQp+XoQ20sWckAfZJcBAzubHdZMOIfxrj8cGedi4g2BJFh8ww3U6I=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o7ECI-0005z4-4n; Fri, 01 Jul 2022 12:48:28 +0200 In-Reply-To: <87o7y96ezm.fsf@dick> (dick r. chiang's message of "Thu, 30 Jun 2022 17:03:25 -0400") X-Now-Playing: Joan as Police Woman's _Enter The Dragon_: "Masquerader" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235776 Archived-At: dick.r.chiang@gmail.com writes: > +(defsubst gnus-server--server-name (which) > + (when-let ((server > + (save-excursion > + (let (prop) > + (while (and (null (setq prop (get-text-property (point-at-bol) which))) > + (zerop (forward-line -1)))) > + prop)))) > + (symbol-name server))) > + > (defun gnus-server-server-name () > - (let ((server (get-text-property (point-at-bol) 'gnus-server))) > - (and server (symbol-name server)))) > + (gnus-server--server-name 'gnus-server)) This will make commands like `gnus-server-yank-server' fail (you can't yank a server after the final server), I think? So this has to be fixed the hard way, like gnus-group-mode does it -- i.e., sprinkle (when (eobp) ...) into the commands where an action on the final line also makes sense to select the final server. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no