From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.devel Subject: Re: feature/fix-the-long-lines-display-bug e7b5912b23: Improvements to long lines handling. Date: Sat, 23 Jul 2022 14:40:53 +0300 Message-ID: <87o7xgcb0a.fsf@tcd.ie> References: <165799889678.19490.7919197387382513250@vcs2.savannah.gnu.org> <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16723"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Gregory Heytings To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 23 13:43:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oFDY2-00049W-Q5 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jul 2022 13:43:54 +0200 Original-Received: from localhost ([::1]:38904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oFDY1-0002yc-K0 for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jul 2022 07:43:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oFDVM-0001hc-SO for emacs-devel@gnu.org; Sat, 23 Jul 2022 07:41:09 -0400 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]:41679) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oFDVH-0001Z8-PA for emacs-devel@gnu.org; Sat, 23 Jul 2022 07:41:07 -0400 Original-Received: by mail-wr1-x42d.google.com with SMTP id n12so9671033wrc.8 for ; Sat, 23 Jul 2022 04:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:in-reply-to:references:date:message-id :user-agent:mime-version; bh=Dh1rywb8jlBxGMYkUoma0mweZm3K65f+yQGDPdUDWh8=; b=aRRv15WeQn8TRzFCcRDjjq5Bl/jAIxaF7SRfXMGnO5ctJgBFIaxq+vTJt6pFU7Ucux NIN+Z8zG9cQc6MSlGTcBv223Qj0nslC86xjubUYv8PJgZWFsNnIQU2R6DFuZfbjlotUl 49EJlQbJv1D0VzB1xGHRJTVpEpqgcVoUUPLGbQFki3rBIvIeT3H4mWFYFAq3RHzbt+as Ew5hT6I7kdxdLpey6FMK3qXLfRUgJ9BsFTcJapJrWOpldxTjGUZuvBkGcMb8IN82rV9e FswHEm8c6aLq1zfuUnkfHsghC0fmVnuKNaUypILSbO3OhiFEYvSmXplt1o6l3ag5UUfV 1XFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:user-agent:mime-version; bh=Dh1rywb8jlBxGMYkUoma0mweZm3K65f+yQGDPdUDWh8=; b=rzRWB8A+rSJRZYVJisVK9VARufi6+bHjI7WOm2mYOKa8hLrf4OC9LTGId4lyXZ1Yez +FfKFx+JT4CJWNIGU1GENy/6DVa1v1mmyrGZ0mzyJQiDG3WnfifBgRuHLpGOK8wQxDQr mBmIJqj5aG8rvdyxhYLAoL+gqEzPT6GZTtcc/PJUfUu64hJCUFfftOHqer9rtlQ9Jwn6 vmtY7oI7gP5yQNHirz//X4goxaINLfAjwtOXlUNsrRI1W1y1Hq+eak+Vf/w/h0/Ge+3g 8dOmM2XHN4R30ldcAziQcRTMLmPA8vG+uepDcYd7OS4vblAsX0vs3wSuqBy13MXQKHx2 oSdw== X-Gm-Message-State: AJIora+LxwJ1Zt5JoppRHdGej76TZz2yLTsw4bPektDGPebPM51acWsb 3+iYu4SpSPPtooYWV4cbkwZhf6LYXhsBNg== X-Google-Smtp-Source: AGRyM1tnpJ0lb6+GQ6x4msviLcK/taJLR1eVgybR91gwCdWUmj82R+f7sHKMtrQDCJt7xXJ5wcmG7Q== X-Received: by 2002:a5d:5a9d:0:b0:21b:8247:7ec4 with SMTP id bp29-20020a5d5a9d000000b0021b82477ec4mr2533574wrb.561.1658576455945; Sat, 23 Jul 2022 04:40:55 -0700 (PDT) Original-Received: from localhost ([2a02:587:320a:74a5:f794:77c1:e192:d382]) by smtp.gmail.com with ESMTPSA id h10-20020a5d548a000000b0021e6c52c921sm2762282wrv.54.2022.07.23.04.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Jul 2022 04:40:55 -0700 (PDT) In-Reply-To: <20220716191457.3B0FAC00095@vcs2.savannah.gnu.org> (Gregory Heytings's message of "Sat, 16 Jul 2022 15:14:56 -0400 (EDT)") Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=contovob@tcd.ie; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292525 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Gregory Heytings [2022-07-16 15:14 -0400] wrote: > branch: feature/fix-the-long-lines-display-bug > commit e7b5912b235936b304701ba6b1e808d9b197fd4f > Author: Gregory Heytings > Commit: Gregory Heytings > > Improvements to long lines handling. >=20=20=20=20=20 > * src/buffer.h (struct buffer): New field 'long_line_optimizations_p'. [...] This seems to have given rise to the following build error with --enable-checking=3Dstructs: pdumper.c: In function =E2=80=98dump_buffer=E2=80=99: pdumper.c:2705:3: error: #error "buffer changed. See CHECK_STRUCTS comment = in config.h." 2705 | # error "buffer changed. See CHECK_STRUCTS comment in config.h." | ^~~~~ Is this the right fix? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Update-pdumper.c-after-recent-long-lines-changes.patch >From ea925aac28cf96fe1ad5736850386e24cc259a7c Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 23 Jul 2022 14:22:09 +0300 Subject: [PATCH] Update pdumper.c after recent long lines changes * src/pdumper.c (dump_buffer): Dump new field long_line_optimizations_p introduced in commit e7b5912b23 of 2022-07-16 "Improvements to long lines handling." (dump_buffer) [CHECK_STRUCTS]: Update hash accordingly for --enable-checking=structs. --- src/pdumper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pdumper.c b/src/pdumper.c index af451920eb..33cb804dba 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -2701,7 +2701,7 @@ dump_hash_table (struct dump_context *ctx, static dump_off dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) { -#if CHECK_STRUCTS && !defined HASH_buffer_F8FE65D42F +#if CHECK_STRUCTS && !defined HASH_buffer_AA373AEE10 # error "buffer changed. See CHECK_STRUCTS comment in config.h." #endif struct buffer munged_buffer = *in_buffer; @@ -2813,6 +2813,7 @@ dump_buffer (struct dump_context *ctx, const struct buffer *in_buffer) DUMP_FIELD_COPY (out, buffer, prevent_redisplay_optimizations_p); DUMP_FIELD_COPY (out, buffer, clip_changed); DUMP_FIELD_COPY (out, buffer, inhibit_buffer_hooks); + DUMP_FIELD_COPY (out, buffer, long_line_optimizations_p); dump_field_lv_rawptr (ctx, out, buffer, &buffer->overlays_before, Lisp_Vectorlike, WEIGHT_NORMAL); -- 2.35.1 --=-=-= Content-Type: text/plain Thanks, -- Basil --=-=-=--