From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Date: Tue, 13 Sep 2022 17:19:54 +0200 Message-ID: <87o7vjxpwl.fsf@gnus.org> References: <87a6iy71q1.fsf@gnus.org> <87v91ct330.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28497"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51368@debbugs.gnu.org, Philipp Stephani To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 13 17:21:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY7iq-0007EM-Vl for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 17:21:12 +0200 Original-Received: from localhost ([::1]:54216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oY7ip-0006Vh-JN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Sep 2022 11:21:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY7ii-0006UF-00 for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 11:21:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35556) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oY7ih-0000gg-Nx for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 11:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oY7ig-0003vx-Ap for bug-gnu-emacs@gnu.org; Tue, 13 Sep 2022 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51368 X-GNU-PR-Package: emacs Original-Received: via spool by 51368-submit@debbugs.gnu.org id=B51368.166308240715002 (code B ref 51368); Tue, 13 Sep 2022 15:21:02 +0000 Original-Received: (at 51368) by debbugs.gnu.org; 13 Sep 2022 15:20:07 +0000 Original-Received: from localhost ([127.0.0.1]:52485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7hn-0003tu-Hd for submit@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY7hl-0003tH-8W for 51368@debbugs.gnu.org; Tue, 13 Sep 2022 11:20:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jyQfmTbHrajhpL01jJZZxdjYkSbVXlpauzrHXKA3kS8=; b=iWCwhi+RksBziULQKK6ApMfT3t cFLarSl1/TPAPYt39LSRT1tql0L0VmAJdx66FB44xSCBnkqISZ74mX7CtyDgYnIUagyIU77eZGful 1NyqTknerkk7B+ADjLfOjIiNngv+aM4nwDN8aCj3C3LWSi1zPC1qSXkNWIPe208ohKDA=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY7hb-000504-0n; Tue, 13 Sep 2022 17:19:57 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 14 Nov 2021 10:08:51 -0500") X-Now-Playing: Nia Andrews's _Modern Love_: "Silly Boy Blue" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242394 Archived-At: Stefan Monnier writes: > BTW, there's a third issue which is that > > (cl-case EXP > ((a b) FOO) > ((a c) BAR)) > > won't warn about the duplicate `a`. > > After fixing this, many/most uses of `quote` will already emit > a warning, so maybe it would make the quote/function part of your second > patch unnecessary. I think it's nice to have an explicit error case for the quote case so that the warning can be better, though, so I've pushed Philipps patches to Emacs 29. But this test case should also emit a warning. Philipp, you don't happen to have a fix for that one, too? =F0=9F=98=80