From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line Date: Sun, 18 Sep 2022 14:45:33 +0200 Message-ID: <87o7vc26mq.fsf@gnus.org> References: <87illme7fe.fsf@gmail.com> <8735cp3pzg.fsf@gnus.org> <83bkrczwhn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2253"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57876@debbugs.gnu.org, public@protesilaos.com, arstoffel@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 14:46:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZtgb-0000RG-KL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 14:46:13 +0200 Original-Received: from localhost ([::1]:38504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZtga-00041D-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 08:46:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50342) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZtgR-000400-6e for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 08:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZtgQ-0002gx-U9 for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 08:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZtgQ-0000LU-Pm for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 08:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 12:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57876 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57876-submit@debbugs.gnu.org id=B57876.16635051441275 (code B ref 57876); Sun, 18 Sep 2022 12:46:02 +0000 Original-Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 12:45:44 +0000 Original-Received: from localhost ([127.0.0.1]:48282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtg8-0000KU-G8 for submit@debbugs.gnu.org; Sun, 18 Sep 2022 08:45:44 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtg7-0000KF-9q for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 08:45:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wOzYmwahoAn5PXc6Zh60kgg/AjKD0nSFEiXrU4u7+BM=; b=WILo5quQL9BETY9mZNPam1yiTB Y6koHslmyOb7ycblM7Rm9DyRXex6GzZeeIJsmaoO8qUyzayNhYlHRAposPpBRCs0JzbEcaPEVBBTu DKPKj5uaAGVaAwKAHzGpZQ2oaYt2YDVm6EWs5AmAc0Hy8vZ6YpeD73N9yJEbF6kNBjeg=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZtfy-0007h1-54; Sun, 18 Sep 2022 14:45:36 +0200 In-Reply-To: <83bkrczwhn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Sep 2022 15:40:36 +0300") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWsmGTGsXW7r5n5 +fnT0c6FdHA6MkL///+d0C9kAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YJEgwTBeNW4yMAAAGUSURB VDjLnZRLcsIwDIYdZtjHPQGYOutME/YZAqw7LvIBGKz7H6GS/MgD6KJaOBp//h3rtxJV6RQl0bXi 0PrQnUuMMgy1gLEDcAAW6HEDMNYNLBJgjLGWBuMkHbTOCgprLRjnSBzBBwME+LY+0D6SRsV+7Dyi R4sEHGLwULbyNOctj3fkNTNAQYrACoqBa9EmgQsP9wzo5fQOfAXKVtcFqAVw9F90JvN5Yk/arFhH O1f8A/TR9gL2YqKx0LBTVCBAiIr9wnY2DKKCgOPF1tPUhjxEKMclr5t7dhcQj1WynXIfmqnyNgPk dQRCSCBvxQDmCj0pFia20iUvwVxx4QpunIWi6LgXF14VsDZRvbuPd6D+Gxw69tXIfZy55V2bvo+e +xKv3NncomR7UvRcgb+C3Aei24miYsANe6H7UAyClVMpPfbZkkAXxYa28SOcvAp4m0CVQbMCegYw gnB8Bg9J34GkIHel8hMX8yOWRGB2ypiNUevQRmv1HKDiD4bMEX9mgKKuK1VJkmdhC1Ji+hFVOhO1 hV/qhvd9Tl5wdwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0xOFQxMjoxOTowNSswMDowMJrK 6TMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMThUMTI6MTk6MDUrMDA6MDDrl1GPAAAAAElF TkSuQmCC X-Now-Playing: The Meters's _Gettin' Funkier All The Time (5): Mister Moon_: "Chug Chug Chug-A-Lug (Push And Shove)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:242983 Archived-At: Eli Zaretskii writes: >> >> This variable is allegedly obsolete since Emacs 25. >> > >> > Sorry, I meant inhibit-field-text-motion. >> >> That variable does not affect what beginning-of-visual-line does >> w.r.t. fields, only invisible text. > > That's not what the doc string of inhibit-field-text-motion does, so > it might be a bug in itself. line-beginning-position, for example, > does ignore fields when that variable is non-nil. Oh, sorry! I was confusing myself by testing with (let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line)) which is the wrong thing, of course -- with inhibit-field-text-motion it works fine. So adjusting the patch to use that instead might be appropriate (but doesn't make much difference).