From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.devel Subject: Re: Amending commits Date: Tue, 27 Sep 2022 08:35:54 -0700 Message-ID: <87o7v0zv6t.fsf@melete.silentflame.com> References: <87h70vbw2f.fsf@gnus.org> <877d1ru3rd.fsf@posteo.net> <87czbjbs4r.fsf@gnus.org> <834jwvmu84.fsf@gnu.org> <87mtama031.fsf@gnus.org> <83bkr2l61a.fsf@gnu.org> <87k05q73c7.fsf@gnus.org> <83a66mku8o.fsf@gnu.org> <878rm559qj.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , philipk@posteo.net, Emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 18:45:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odDhm-000946-N6 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 18:45:11 +0200 Original-Received: from localhost ([::1]:46618 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odDhk-0003QA-01 for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 12:45:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCcs-0007Dp-4L for Emacs-devel@gnu.org; Tue, 27 Sep 2022 11:36:02 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59667) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odCco-00067i-Oa; Tue, 27 Sep 2022 11:36:01 -0400 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 555C85C00AE; Tue, 27 Sep 2022 11:35:56 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Sep 2022 11:35:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664292956; x=1664379356; bh=Do dud/0hJyx8LwsW7aYxBKL9T4vMjPCXIsX9RZL3QPo=; b=n1odrrKqUHgmXkPaAj oQEyhEDSqf9p12Qe1PRL2R7f/jGTK27Ta/qfGlwYm5XcOptuBzriX1Khy6epievq GkyWEB+NMyu/nFa2I2PVdbR94rRP4rJtLBktYQGFzDayy8Ggl7H7XSlMW4BEpu++ z58IuhBQKKz/vO1SxZcRy+B2bn0nWICRtlSLx1AyvhbQ+A5L3XhbZwLPHi+tdwIq 8K0/14Q26IXh9TXmMamfU6/NuNf/ph9by2mq7JC47aTVX+KLgvb5228QLldNZDxy 31ZJtE6iPHT7mv+vxebJAAo9oXoY/CTfw3+V4uC70ZFPf59cDNAEAozHDC3UjVD7 rL3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664292956; x=1664379356; bh=Dodud/0hJyx8LwsW7aYxBKL9T4vM jPCXIsX9RZL3QPo=; b=iLDCCjpbblxMqyozTNN5LDJ/WLoEYZYt2nINm4xtLdgB 1caY13NiImVwURperlm/kdpBumGv6mdwG7RZEj/9p5fwPXLVWYdbS++ejVpVnnOh 28wK7ozshuTa7VxDzAAvQ4gbl3rAMwjfziBzR6yJvmPo3fI+hOmALSnuX8uLZ+eR 5lOOxYC7LHDDDHR89ZOPIpzWUiDjH1N4HD62exLEUMvGzzNLUh9vVoQqANiUmM4i ZgcaSseibqBAmbdvPDQWVbl+NjoKfU9u/qe3XcxwNe8En8kwDywJyAoXTlCMRAD+ jrUil2K7rWvUSmBROjmGlXTXQJ++NzVnlO+VMXkicw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegiedgieeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 11:35:56 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 52E477E0F39; Tue, 27 Sep 2022 08:35:54 -0700 (MST) In-Reply-To: <878rm559qj.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Sep 2022 13:37:24 +0200") Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296352 Archived-At: Hello, On Tue 27 Sep 2022 at 01:37PM +02, Lars Ingebrigtsen wrote: > Eli Zaretskii writes: > >>> A vc-checkin without anything to check in? I didn't know that that was >>> possible, and it doesn't seem like a natural work flow. >> >> It's no less natural than "git commit --amend" from the command line. > > Which is pretty unnatural. > > So I guess the conclusion here is that I should just go ahead and add a > vc command that does the right thing for this use case. There is already vc-modify-change-comment which I think just needs a Git backend implementation. Then it'll work from Log View. -- Sean Whitton