all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <Michael.Albinus@gmx.de>
To: Brian Cully <bjc@spork.org>
Cc: miha@kamnitnik.top,  Brian Cully <bjc@kublai.com>,  emacs-devel@gnu.org
Subject: Re: master 152c7322c1: * lisp/net/tramp-docker.el: New file.
Date: Mon, 03 Oct 2022 19:37:33 +0200	[thread overview]
Message-ID: <87o7usolk2.fsf@gmx.de> (raw)
In-Reply-To: <b294e472-a74b-bb5f-afc6-de5e9a5a6b94@spork.org> (Brian Cully's message of "Mon, 3 Oct 2022 09:44:16 -0400")

Brian Cully <bjc@spork.org> writes:

Hi Brian,

> Indeed. I hadn't considered this use-case (even though I also have
> both installed, though I only use Tramp with Podman containers for
> development purposes).
>
> As the package is really not much more than the method and variable
> customization options, it may be best to just have duplicates for
> those (eg, both `tramp-docker-program' and
> `tramp-podman-program'). The completion code could be shared, but I'm
> unsure how higher-level code organization would work. My first pass
> would be to have a single `tramp-docker--completion-function' which is
> used for both the `tramp-podman-method' as well as
> `tramp-docker-method'. My rationale being that Podman explicitly
> copies the Docker command line so that at can be used as a drop-in
> replacement, so the completion function would more naturally be
> associated with Docker than Podman.

OK. Would you like to provide a patch? Including a ChangeLog-like commit
message.

> -bjc

Best regards, Michael.



  reply	other threads:[~2022-10-03 17:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29 16:50 master 152c7322c1: * lisp/net/tramp-docker.el: New file miha
2022-09-29 17:28 ` Michael Albinus
2022-10-03 13:44   ` Brian Cully via Emacs development discussions.
2022-10-03 17:37     ` Michael Albinus [this message]
2022-10-04 15:32       ` Brian Cully via Emacs development discussions.
2022-10-04 16:58         ` Michael Albinus
2022-10-04 17:43           ` Brian Cully via Emacs development discussions.
2022-10-04 18:00             ` Michael Albinus
2022-10-04 18:17               ` Brian Cully via Emacs development discussions.
2022-10-04 18:20                 ` Michael Albinus
2022-10-04 18:33                   ` Brian Cully via Emacs development discussions.
2022-10-04 18:36                     ` Michael Albinus
2022-10-04 18:45                       ` Brian Cully via Emacs development discussions.
2022-10-04 19:21                         ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7usolk2.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=bjc@kublai.com \
    --cc=bjc@spork.org \
    --cc=emacs-devel@gnu.org \
    --cc=miha@kamnitnik.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.