bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]



Hi the following bug report concerns 
commit 93136169cba9c7c8f82

When compiling with the option 
 --with-x-toolkit=athena 

Or to be precise 

    1) I run ./configure --prefix=/opt/emacs29 --with-x-toolkit=athena --without-pop --with-mailutils
    2) I run make bootstrap
    3) make
    4) cd src
    5) ./emacs -Q
    6) I obtain two screens I attach

When I repeat the steps without the --with-x-toolkit=athena
option, everything is fine

regards

Uwe Brauer 

[-- Attachment #2: emacs-windows1.png --]
[-- Type: image/png, Size: 84007 bytes --]

[-- Attachment #3: emacs-windows.png --]
[-- Type: image/png, Size: 265883 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> Hi the following bug report concerns 
> commit 93136169cba9c7c8f82
>
> When compiling with the option 
>  --with-x-toolkit=athena 
>
> Or to be precise 
>
>     1) I run ./configure --prefix=/opt/emacs29 --with-x-toolkit=athena --without-pop --with-mailutils
>     2) I run make bootstrap
>     3) make
>     4) cd src
>     5) ./emacs -Q
>     6) I obtain two screens I attach
>
> When I repeat the steps without the --with-x-toolkit=athena
> option, everything is fine
>
> regards
>
> Uwe Brauer 

What version of KWin is that?

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Hi the following bug report concerns 
>> commit 93136169cba9c7c8f82
>> 
>> When compiling with the option 
>> --with-x-toolkit=athena 
>> 
>> Or to be precise 
>> 
>> 1) I run ./configure --prefix=/opt/emacs29 --with-x-toolkit=athena --without-pop --with-mailutils
>> 2) I run make bootstrap
>> 3) make
>> 4) cd src
>> 5) ./emacs -Q
>> 6) I obtain two screens I attach
>> 
>> When I repeat the steps without the --with-x-toolkit=athena
>> option, everything is fine
>> 
>> regards
>> 
>> Uwe Brauer 

> What version of KWin is that?

I am on Ubuntu 16.04 with trinity https://www.trinitydesktop.org/

How do I find out?

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> I am on Ubuntu 16.04 with trinity https://www.trinitydesktop.org/

Thanks, I will look into this.

bug#58412: [Problems also without athena] (was: bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window)

[Uwe Brauer]

[-- Attachment #1.1: Type: text/plain, Size: 602 bytes --]


> Uwe Brauer <oub@mat.ucm.es> writes:

> What version of KWin is that?

I just start working with the non athena version, opening  a file also causes emacs to shrink dramatically and I end up with something very ugly, screenshot attached.

And obtaining message like 
(emacs:17059): Gtk-CRITICAL **: gtk_distribute_natural_allocation: assertion 'extra_space >= 0' failed




-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #1.2: emacs-no-athena.png --]
[-- Type: image/png, Size: 115914 bytes --]

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> And obtaining message like 
> (emacs:17059): Gtk-CRITICAL **: gtk_distribute_natural_allocation: assertion 'extra_space >= 0' failed

That's a bug in GTK.

Please do NOT change the subject line (which I restored) in bug reports,
thanks.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> And obtaining message like 
>> (emacs:17059): Gtk-CRITICAL **: gtk_distribute_natural_allocation: assertion 'extra_space >= 0' failed

> That's a bug in GTK.

Ok, but right now I cannot upgrade GTK, so in earlier master versions, I
had no problem, so could there be a fix on the Emacs side?

> Please do NOT change the subject line (which I restored) in bug reports,
> thanks.

Ok


-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> Ok, but right now I cannot upgrade GTK, so in earlier master versions, I
> had no problem, so could there be a fix on the Emacs side?

I don't know.  If you bisect to the change in Emacs that causes it, then
I could probably fix it.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Ok, but right now I cannot upgrade GTK, so in earlier master versions, I
>> had no problem, so could there be a fix on the Emacs side?

> I don't know.  If you bisect to the change in Emacs that causes it, then
> I could probably fix it.

Ok, sigh, I was afraid of that, but fair enough, and currently master
has some nice new exiting features I would like to test.

I try that later today. 

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> Ok, sigh, I was afraid of that, but fair enough, and currently master
> has some nice new exiting features I would like to test.

BTW, screwing around with the Kwin in Trinity did not result in the bug
for me, so it would be nice if you could bisect for that as well.

Thanks.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 1306 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> Ok, sigh, I was afraid of that, but fair enough, and currently master
>> has some nice new exiting features I would like to test.

> BTW, screwing around with the Kwin in Trinity did not result in the bug
> for me, so it would be nice if you could bisect for that as well.

I found it, *you* are the culprit 😉

It is commit  136495f178cc

* commit 136495f178ccd36b23ffc347fe2b6680fd689e34
│  Author: Po Lu <luangruo@yahoo.com>
│  Date: Wed, 31 Aug 2022 10:17:20 +0800
│
│  Gently nudge Xt into always setting size hints
│
│  * src/widget.c (update_wm_hints): Force a resource to change
│  every time this function is called.  (bug#57475)
│  (EmacsFrameInitialize): Initialize new field.
│  * src/widgetprv.h (EmacsFramePart): New field `size_switch'.
│  * src/xterm.c (x_wm_set_size_hint): Don't change flags if flags
│  is 0.

That causes the problem with and without athena. So it is responsible
for both problems.

I hope that can be solved.


-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

>>>> "PL" == Po Lu <luangruo@yahoo.com> writes:
>
>> Uwe Brauer <oub@mat.ucm.es> writes:
>>> Ok, sigh, I was afraid of that, but fair enough, and currently master
>>> has some nice new exiting features I would like to test.
>
>> BTW, screwing around with the Kwin in Trinity did not result in the bug
>> for me, so it would be nice if you could bisect for that as well.
>
> I found it, *you* are the culprit 😉
>
> It is commit  136495f178cc
>
> * commit 136495f178ccd36b23ffc347fe2b6680fd689e34
> │  Author: Po Lu <luangruo@yahoo.com>
> │  Date: Wed, 31 Aug 2022 10:17:20 +0800
> │
> │  Gently nudge Xt into always setting size hints
> │
> │  * src/widget.c (update_wm_hints): Force a resource to change
> │  every time this function is called.  (bug#57475)
> │  (EmacsFrameInitialize): Initialize new field.
> │  * src/widgetprv.h (EmacsFramePart): New field `size_switch'.
> │  * src/xterm.c (x_wm_set_size_hint): Don't change flags if flags
> │  is 0.
>
> That causes the problem with and without athena. So it is responsible
> for both problems.

Did you test with GTK during the bisection as well?  That code only
affects the X toolkit builds.

Also, what happens if you remove the change to widget.c?

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]


> Uwe Brauer <oub@mat.ucm.es> writes:

> Did you test with GTK during the bisection as well?  That code only
> affects the X toolkit builds.

You mean for all 9 tests I had to run? No, because then I would have to
run make clean after each compile, right? 
That would have doubled my time and it took me the whole afternoon to
run the test, my Thinkpad is from 2017.

> Also, what happens if you remove the change to widget.c?

You mean I revert that particular change to the commit just before? 
I will do that now and report back


Once that is solved, I will try to test the GTK stuff.

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

>> Uwe Brauer <oub@mat.ucm.es> writes:
>
>> Did you test with GTK during the bisection as well?  That code only
>> affects the X toolkit builds.
>
> You mean for all 9 tests I had to run? No, because then I would have to
> run make clean after each compile, right? 

Just a build, you don't need to run "make clean" to switch toolkits.

> You mean I revert that particular change to the commit just before? 
> I will do that now and report back

Yes, just the change in widget.c.  Thank you.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]


> Uwe Brauer <oub@mat.ucm.es> writes:

> Did you test with GTK during the bisection as well?  That code only
> affects the X toolkit builds.

> Also, what happens if you remove the change to widget.c?


I did this now, and run 

Make clean
make boostrap 

Again (not sure whether this necessary)

Be it as it may, this *solves* my issue. So this code in widget.c screws
up my athena setting.

I am waiting for a solution to this problem, before continuing to bisect
the GTK problem.


-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> I did this now, and run 
>
> Make clean
> make boostrap 
>
> Again (not sure whether this necessary)
>
> Be it as it may, this *solves* my issue. So this code in widget.c screws
> up my athena setting.

Unfortunately, without it, frame placement is screwed up for everyone
else.  I will push what is hopefully a fix shortly.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> I did this now, and run 
>> 
>> Make clean
>> make boostrap 
>> 
>> Again (not sure whether this necessary)
>> 
>> Be it as it may, this *solves* my issue. So this code in widget.c screws
>> up my athena setting.

> Unfortunately, without it, frame placement is screwed up for everyone
> else.  I will push what is hopefully a fix shortly.

I would appreciate that. Thanks 



-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> I would appreciate that. Thanks 

Now done.  Please test, thanks.

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Uwe Brauer]

[-- Attachment #1: Type: text/plain, Size: 500 bytes --]

>>> "PL" == Po Lu <luangruo@yahoo.com> writes:

> Uwe Brauer <oub@mat.ucm.es> writes:
>> I would appreciate that. Thanks 

> Now done.  Please test, thanks.

I pulled, run run make clean, just in case, run configure with athena and compiled:

Issue solved, thanks very much!

-- 
I strongly condemn Putin's war of aggression against the Ukraine.
I support to deliver weapons to Ukraine's military. 
I support the ban of Russia from SWIFT.
I support the EU membership of the Ukraine. 

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5673 bytes --]

bug#58412: 29.0.50; --with-x-toolkit=athena causes too small emacs window

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Uwe Brauer <oub@mat.ucm.es> writes:

> I pulled, run run make clean, just in case, run configure with athena and compiled:
>
> Issue solved, thanks very much!

Thanks, then I'm closing this bug.  Please open a new report about the
GTK one.