all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Detlef Steuer <steuer@hsu-hh.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] improved: add TTL as defcustom to ox-icalendar
Date: Wed, 09 Nov 2022 06:57:17 +0000	[thread overview]
Message-ID: <87o7tgaa42.fsf@localhost> (raw)
In-Reply-To: <20220103123253.6bb48655@hsu-hh.de>

Detlef Steuer <steuer@hsu-hh.de> writes:

>> I think, it is better to wait for comments from an ox-icalendar user.
>
> Sure.

Sorry for the late reply.
I am not a user, but will the patch looks reasonable in general.

>> I am afraid, you will be tired trying to convince me that TTL should
>> be overridden for all users (not to say that I am not a maintainer).
>
> No, that wasn't my intention. Just tried to explain.

I agree that it is not a good idea to force-override server defaults.
Instead, I'd prefer the defcustom to default to nil (no TTL inserted)
and other possible values documented and listed in :type defcustom
argument.

>> >> https://orgmode.org/worg/org-contribute.html for some hints
>> >> addressed to contributors.  
>> 
>> I am not completely sure, but you patch may exceed "TINYCHANGE"
>> limit, so signing FSF copyright papers may be a prerequisite to
>> accept your patch.
>>
>
> Hmm, probably a good idea anyway.

The patch is on the edge, probably still acceptable without copyright
assignment. If you have it, it would be much better though.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2022-11-09  6:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-30 21:59 [patch] add TTL as defcustom to ox-icalendar Detlef Steuer
2022-01-02 13:28 ` [patch] improved: " Detlef Steuer
2022-01-03  6:08   ` Max Nikulin
2022-01-03  7:41     ` Detlef Steuer
2022-01-03 11:23       ` Max Nikulin
2022-01-03 11:32         ` Detlef Steuer
2022-11-09  6:57           ` Ihor Radchenko [this message]
     [not found]             ` <20221109082520.066dc4c6@linux.fritz.box>
2022-11-09  7:58               ` Ihor Radchenko
2022-11-09  8:32                 ` Bastien Guerry
     [not found]               ` <20230113181035.1469ab37@hsu-hh.de>
     [not found]                 ` <878ri52z06.fsf@localhost>
2023-01-16 22:42                   ` Detlef Steuer
2023-01-17  9:43                     ` Ihor Radchenko
2023-01-17 10:03                       ` Detlef Steuer
2023-01-17 10:30                         ` Ihor Radchenko
2023-02-03 13:25                           ` Detlef Steuer
2023-02-04 11:09                             ` Ihor Radchenko
2023-02-04 21:01                               ` Detlef Steuer
2023-02-05 11:09                                 ` Ihor Radchenko
2024-01-27  5:00                                   ` Jack Kamm
2024-01-28 13:42                                     ` Ihor Radchenko
2024-01-28 21:50                                       ` Jack Kamm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7tgaa42.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=steuer@hsu-hh.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.