Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.

Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.

[Po Lu]

Mattias Engdegård <mattiase@acm.org> writes:

> branch: master
> commit 8dc36cc53b7c2b66ca06ca4db84209bc492ea665
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     * src/lread.c (syms_of_lread): Drop unused capture group.
> ---
>  src/lread.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/lread.c b/src/lread.c
> index 957bc6895e..c28324dc35 100644
> --- a/src/lread.c
> +++ b/src/lread.c
> @@ -5620,7 +5620,8 @@ from the file, and matches them against this regular expression.
>  When the regular expression matches, the file is considered to be safe
>  to load.  */);
>    Vbytecomp_version_regexp
> -    = build_pure_c_string ("^;;;.\\(in Emacs version\\|bytecomp version FSF\\)");
> +    = build_pure_c_string
> +        ("^;;;.\\(?:in Emacs version\\|bytecomp version FSF\\)");

Isn't it not our style to put the only line of parameter to a function
call on a new line?  Here, I would split the string in two, like so,
instead:

  build_pure_c_string ("long string here"
  		       " next part of string here");

Re: master 8dc36cc53b: * src/lread.c (syms_of_lread): Drop unused capture group.

[Mattias Engdegård]

9 nov. 2022 kl. 13.19 skrev Po Lu <luangruo@yahoo.com>:

> I would split the string in two, like so,
> instead:
> 
>  build_pure_c_string ("long string here"
>  		       " next part of string here");

Yes, that would be fine too. As so often when it comes to code layout, neither alternative dominates the other.