From: Robert Pluim <rpluim@gmail.com>
To: emacs-devel@gnu.org
Cc: Gregory Heytings <gregory@heytings.org>, Juri Linkov <juri@linkov.net>
Subject: Re: emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially.
Date: Fri, 13 Jan 2023 13:49:47 +0100 [thread overview]
Message-ID: <87o7r2eh04.fsf@gmail.com> (raw)
In-Reply-To: <20230112174816.7E88BC00A7F@vcs2.savannah.gnu.org> (Juri Linkov's message of "Thu, 12 Jan 2023 12:48:16 -0500 (EST)")
>>>>> On Thu, 12 Jan 2023 12:48:16 -0500 (EST), Juri Linkov <juri@jurta.org> said:
Juri> branch: emacs-29
Juri> commit 9ecebcdded157e1efc2f51b67967fd101797f225
Juri> Author: Gregory Heytings <gregory@heytings.org>
Juri> Commit: Juri Linkov <juri@linkov.net>
Juri> * lisp/simple.el (next-completion): Handle first completion specially.
Juri> When completions-header-format is nil and completion-show-help is nil,
Juri> the first completion is at the beginning the buffer, so 'M-<down>'
Juri> missed it and moved to the second completion. Handle this case by
Juri> setting/checking the special text-property 'first-completion' that
Juri> is nil at the first call (bug#60411).
This causes the following test failure for me:
Making completion list...
Test completions-header-format-test backtrace:
signal(ert-test-failed (((should (equal "ac" (get-text-property (poi
ert-fail(((should (equal "ac" (get-text-property (point) 'completion
#f(compiled-function () #<bytecode -0x141bfad86d70e309>)()
minibuffer-setup()
read-from-minibuffer("Prompt: " nil (keymap (menu-bar keymap (minibu
completing-read-default("Prompt: " ("aa" "ab" "ac") nil nil nil nil
completing-read("Prompt: " ("aa" "ab" "ac"))
#f(compiled-function () #<bytecode -0x1b72fd9b89f49f74>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name completions-header-format-test :docum
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/minibuffer-tests" "-
command-line()
normal-top-level()
Test completions-header-format-test condition:
(ert-test-failed
((should
(equal "ac"
(get-text-property ... ...)))
:form
(equal "ac"
#("ab" 0 1
(face ...)
1 2
(face ...)))
:value nil :explanation
(array-elt 1
(different-atoms
(99 "#x63" "?c")
(98 "#x62" "?b")))))
FAILED 25/25 completions-header-format-test (0.000478 sec) at lisp/minibuffer-tests.el:414
Robert
--
next parent reply other threads:[~2023-01-13 12:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167354569613.4370.3805904095626587994@vcs2.savannah.gnu.org>
[not found] ` <20230112174816.7E88BC00A7F@vcs2.savannah.gnu.org>
2023-01-13 12:49 ` Robert Pluim [this message]
2023-01-13 13:37 ` emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially Eli Zaretskii
2023-01-13 13:57 ` Robert Pluim
2023-01-13 14:57 ` Eli Zaretskii
2023-01-14 17:17 ` Juri Linkov
2023-01-14 18:57 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7r2eh04.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.