org-habit and hourly repeats

org-habit and hourly repeats

[Felipe Balbi]

Hi,

I'm trying to start using `org-habit' but I noticed that hourly repeats
are not properly parsed by `org-habit-duration-to-days', however that's
a valid use case --- e.g. drinking water, medicine schedule,
physiotherapy sessions during the day, periodically practicing a new
language. For example, here's an easy TODO item that reproduces the
problem:

8< -------------------- cut here --------------------

* TODO Foo
  SCHEDULED: <2023-01-18 Wed 11:00 .+8h>
  :PROPERTIES:
  :STYLE:    habit
  :END:

8< -------------------- cut here --------------------

It appears that a simple solution would be modify
`org-habit-duration-to-days' to accept the `h' suffix and set it to a
fraction of a day, something like:

8< -------------------- cut here --------------------

(defun org-habit-duration-to-days (ts)
  (if (string-match "\\([0-9]+\\)\\([hdwmy]\\)" ts)
      ;; lead time is specified.
      (floor (* (string-to-number (match-string 1 ts))
		(cdr (assoc (match-string 2 ts)
			    '(("h" . 0.042) ("d" . 1)
                              ("w" . 7)     ("m" . 30.4)
                              ("y" . 365.25))))))
    (error "Invalid duration string: %s" ts)))

8< -------------------- cut here --------------------

Would something like this be an acceptable solution?

-- 
balbi

Re: org-habit and hourly repeats

[Ihor Radchenko]

Felipe Balbi <balbi@kernel.org> writes:

> I'm trying to start using `org-habit' but I noticed that hourly repeats
> are not properly parsed by `org-habit-duration-to-days', however that's
> a valid use case --- e.g. drinking water, medicine schedule,
> physiotherapy sessions during the day, periodically practicing a new
> language. For example, here's an easy TODO item that reproduces the
> problem:

Habits occurring multiple times a day are not properly supported in
general. See https://list.orgmode.org/orgmode/87leplsggg.fsf@localhost/

> It appears that a simple solution would be modify
> `org-habit-duration-to-days' to accept the `h' suffix and set it to a
> fraction of a day, something like:
>
> 8< -------------------- cut here --------------------
>
> (defun org-habit-duration-to-days (ts)
>   (if (string-match "\\([0-9]+\\)\\([hdwmy]\\)" ts)
>       ;; lead time is specified.
>       (floor (* (string-to-number (match-string 1 ts))
> 		(cdr (assoc (match-string 2 ts)
> 			    '(("h" . 0.042) ("d" . 1)
>                               ("w" . 7)     ("m" . 30.4)
>                               ("y" . 365.25))))))
>     (error "Invalid duration string: %s" ts)))
>
> 8< -------------------- cut here --------------------
>
> Would something like this be an acceptable solution?

I afraid that things are not that simple.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-habit and hourly repeats

[Felipe Balbi]

Hi,

On Thu, Jan 19, 2023 at 12:47 PM Ihor Radchenko <yantar92@posteo.net> wrote:
>
> Felipe Balbi <balbi@kernel.org> writes:
>
> > I'm trying to start using `org-habit' but I noticed that hourly repeats
> > are not properly parsed by `org-habit-duration-to-days', however that's
> > a valid use case --- e.g. drinking water, medicine schedule,
> > physiotherapy sessions during the day, periodically practicing a new
> > language. For example, here's an easy TODO item that reproduces the
> > problem:
>
> Habits occurring multiple times a day are not properly supported in
> general. See https://list.orgmode.org/orgmode/87leplsggg.fsf@localhost/

That's very interesting, because repeated tasks clearly mention hourly repeats:

https://orgmode.org/manual/Repeated-tasks.html

"You can use yearly, monthly, weekly, daily and hourly repeat cookies by
using the ‘y’, ‘m’, ‘w’, ‘d’ and ‘h’ letters."

>
> > It appears that a simple solution would be modify
> > `org-habit-duration-to-days' to accept the `h' suffix and set it to a
> > fraction of a day, something like:
> >
> > 8< -------------------- cut here --------------------
> >
> > (defun org-habit-duration-to-days (ts)
> >   (if (string-match "\\([0-9]+\\)\\([hdwmy]\\)" ts)
> >       ;; lead time is specified.
> >       (floor (* (string-to-number (match-string 1 ts))
> >               (cdr (assoc (match-string 2 ts)
> >                           '(("h" . 0.042) ("d" . 1)
> >                               ("w" . 7)     ("m" . 30.4)
> >                               ("y" . 365.25))))))
> >     (error "Invalid duration string: %s" ts)))
> >
> > 8< -------------------- cut here --------------------
> >
> > Would something like this be an acceptable solution?
>
> I afraid that things are not that simple.

Do you mind expanding on this? Just generally curious, really.

-- 
balbi

Re: org-habit and hourly repeats

[Ihor Radchenko]

Felipe Balbi <balbi@kernel.org> writes:

>> Habits occurring multiple times a day are not properly supported in
>> general. See https://list.orgmode.org/orgmode/87leplsggg.fsf@localhost/
>
> That's very interesting, because repeated tasks clearly mention hourly repeats:
>
> https://orgmode.org/manual/Repeated-tasks.html
>
> "You can use yearly, monthly, weekly, daily and hourly repeat cookies by
> using the ‘y’, ‘m’, ‘w’, ‘d’ and ‘h’ letters."

Repeated tasks do support hourly repeats. But not habits, as long as
habit-specific logic is concerned.

>> I afraid that things are not that simple.
>
> Do you mind expanding on this? Just generally curious, really.

I tried to list some things in
https://list.orgmode.org/orgmode/87leplsggg.fsf@localhost/

For example, habit consistency graph assumes that habits are repeated
every day or longer.

Generally, adding hourly habits will require careful checking of
org-habit.el code. In addition, org-agenda cannot display repeated tasks
when their repeat interval is less than a day (it is a minor annoyance
though; should not be a blocker)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

Re: org-habit and hourly repeats

[Felipe Balbi]

Hi,

On Thu, Jan 19, 2023 at 1:03 PM Ihor Radchenko <yantar92@posteo.net> wrote:
> > That's very interesting, because repeated tasks clearly mention hourly repeats:
> >
> > https://orgmode.org/manual/Repeated-tasks.html
> >
> > "You can use yearly, monthly, weekly, daily and hourly repeat cookies by
> > using the ‘y’, ‘m’, ‘w’, ‘d’ and ‘h’ letters."
>
> Repeated tasks do support hourly repeats. But not habits, as long as
> habit-specific logic is concerned.

Got it :-)

> >> I afraid that things are not that simple.
> >
> > Do you mind expanding on this? Just generally curious, really.
>
> I tried to list some things in
> https://list.orgmode.org/orgmode/87leplsggg.fsf@localhost/
>
> For example, habit consistency graph assumes that habits are repeated
> every day or longer.
>
> Generally, adding hourly habits will require careful checking of
> org-habit.el code. In addition, org-agenda cannot display repeated tasks
> when their repeat interval is less than a day (it is a minor annoyance
> though; should not be a blocker)

Thanks for the links and information. It's unfortunate that it's not supported,
but I guess I can live with it, no problem :-)

cheers

--
balbi

Re: org-habit and hourly repeats

[Ihor Radchenko]

Felipe Balbi <balbi@kernel.org> writes:

> Thanks for the links and information. It's unfortunate that it's not supported,
> but I guess I can live with it, no problem :-)

Patches welcome ;)
Feel free to ask anything if you want to figure out how org-habit code
works.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>