From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: arstoffel@gmail.com, 61553@debbugs.gnu.org
Subject: bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice
Date: Fri, 17 Feb 2023 13:42:35 +0100 [thread overview]
Message-ID: <87o7ps1n0k.fsf@gmail.com> (raw)
In-Reply-To: <83h6vk1njp.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 Feb 2023 14:31:06 +0200")
>>>>> On Fri, 17 Feb 2023 14:31:06 +0200, Eli Zaretskii <eliz@gnu.org> said:
>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Augusto Stoffel <arstoffel@gmail.com>, 61553@debbugs.gnu.org
>> Date: Fri, 17 Feb 2023 11:24:09 +0100
>>
>> >>>>> On Thu, 16 Feb 2023 22:17:18 +0200, Eli Zaretskii <eliz@gnu.org> said:
>>
>> >> So instead of adding a special case for kill-buffer, I would rather
>> >> modify the behavior of RMC to just ignore the long-form argument if
>> >> (use-dialog-box-p) returns t. Apart from that, your patch seems fine.
>>
Eli> I disagree that rmc.el should make that decision. It isn't its call
Eli> (pun intended).
>>
>> If we do this then we need to modify the docstring of
>> `read-multiple-choice', which explicitly defines the current
>> behaviour:
>>
>> When `use-dialog-box' is t (the default), and the command using this
>> function was invoked via the mouse, this function pops up a GUI dialog
>> to collect the user input, but only if Emacs is capable of using GUI
>> dialogs. Otherwise, the function will always use text-mode dialogs.
>>
>> The return value is the matching entry from the CHOICES list.
>>
>> If LONG-FORM, do a `completing-read' over the NAME elements in
>> CHOICES instead.
Eli> Where exactly is the above wrong?
Itʼs not wrong, it just could be clearer.
Eli> The only problem I found in that function is that it evidently was
Eli> never actually tested with GUI dialogs, because trying to do that
Eli> revealed at least two (albeit minor) issues with what it did in that
Eli> case. Both of them are solved in the patch I proposed.
>> Although perhaps we could clarify it:
>>
>> If LONG-FORM, always do a `completing-read' over the NAME elements in
>> CHOICES instead, regardless of the value of `use-dialog-box'.
Eli> Oh, you assume that the reader will not understand that
Eli> completing-read cannot possibly use GUI dialogs? I'm okay with saying
Eli> that explicitly, although someone who uses these APIs must already
Eli> realize that.
I had to read it carefully to realize that the 'instead' referred to
the use of dialogs.
Robert
--
next prev parent reply other threads:[~2023-02-17 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:19 bug#61553: 29.0.60; Inconsistent use of dialog boxes by read-multiple-choice Augusto Stoffel
2023-02-16 17:59 ` Eli Zaretskii
2023-02-16 18:36 ` Augusto Stoffel
2023-02-16 20:17 ` Eli Zaretskii
2023-02-17 10:24 ` Robert Pluim
2023-02-17 12:31 ` Eli Zaretskii
2023-02-17 12:42 ` Robert Pluim [this message]
2023-02-19 9:32 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ps1n0k.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=61553@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.