From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62417: 30.0.50; Regression: 59ecf25fc860 is the first bad commit Date: Fri, 24 Mar 2023 15:22:27 +0000 Message-ID: <87o7oicgy4.fsf@gmail.com> References: <87sfducmrc.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33144"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Philip Kaludercic To: 62417@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 24 23:05:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfpWz-0008SU-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 24 Mar 2023 23:05:05 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfpTg-0004RV-Ii; Fri, 24 Mar 2023 18:01:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfpTM-0004BW-D7 for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:21 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfpTL-0000eY-15 for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 18:01:20 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfjhx-0005XL-Mq for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 11:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 15:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62417 X-GNU-PR-Package: emacs Original-Received: via spool by 62417-submit@debbugs.gnu.org id=B62417.167967310921263 (code B ref 62417); Fri, 24 Mar 2023 15:52:01 +0000 Original-Received: (at 62417) by debbugs.gnu.org; 24 Mar 2023 15:51:49 +0000 Original-Received: from localhost ([127.0.0.1]:41180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjhk-0005Wt-Kq for submit@debbugs.gnu.org; Fri, 24 Mar 2023 11:51:48 -0400 Original-Received: from mail-lj1-f171.google.com ([209.85.208.171]:36754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfjhj-0005Wf-GY for 62417@debbugs.gnu.org; Fri, 24 Mar 2023 11:51:48 -0400 Original-Received: by mail-lj1-f171.google.com with SMTP id g18so2214169ljl.3 for <62417@debbugs.gnu.org>; Fri, 24 Mar 2023 08:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679673098; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WZ+81Y1I3IfUU2kYwpwgT5j55NTQiSBNKwRYWkwU6hk=; b=e0VQEYGfm0rff+9vK+wWC+C9h6R8nGPoYBcoyi8aaZw7WJTdn4a1RMt8abMI+XzUSr IDD0noHmFPOawhi1X9FAWZfaEVDnvSvzQzClbWsrHgT8STymADd+YODrMxGH+7FP8nj5 aI6w+etTNBRyKeJ89VVKZ8OpGaUHmcaywmSFPGM8x1cdvLYdeIvhT7iT/jF4B8oefIOD v3jt0aB0Cdn3SAx/R7TQkApTtFRmIj7bsnb2IvmIvDlyaCvaQ/bUGI58vtZRrOtDj59T 0bkjBjRKlU4d0BhLj+Eo6+njsP/ZsM8yWffZo7aMXI/I95IBajJl5Oz8nSCbJehhaTHg nxkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679673098; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WZ+81Y1I3IfUU2kYwpwgT5j55NTQiSBNKwRYWkwU6hk=; b=NDgvgIKH4E5yNaXXW/3C3dmZDe+gbzXNcE9gkqDzIGSkK/xbzK/uPrOnTdCAgiavPJ yodV4LprJ56OjiiZXkKudnLDsGVDVBWhJkddCYQ7wFYpMVJ+05yvagd0E4SgpUdDBe6i YG6kr1QF+tOimCMcXwj0dTsk9jDlmTEv9k128cdBAi7/armXRAH1NPra43HFtGj1hH4E DWkUXAksxY0Mqfqw4ZlQEFFx5SLUxYoGT1r1pxwk/kpUCfXvZCJLnCdsRvDm23FVQt46 CqwnGA+FYhONMNTNAtaB+4pB1we18mNflIaJVSWK3pDhG1gwWdT5/MQ6AlYvtIrwVjPk 3RXQ== X-Gm-Message-State: AAQBX9dF5mhKqzqWWZV30YpaKnlVi82lUeQGyNH3rE1fPeheAsUSUBYV a8f+UXTcly3vnkn1M8Zxt+H1qv7FxO8= X-Google-Smtp-Source: AKy350ZNcdXKLjdGtCqpj5eL6VjrYZ4zncV9cHUuXLLUPnYb0KLQ1B0K7VeT/l8QwHBK4uptMCJ42w== X-Received: by 2002:a17:907:8687:b0:933:499e:62a7 with SMTP id qa7-20020a170907868700b00933499e62a7mr3602673ejc.49.1679671226645; Fri, 24 Mar 2023 08:20:26 -0700 (PDT) Original-Received: from krug (87-196-72-75.net.novis.pt. [87.196.72.75]) by smtp.gmail.com with ESMTPSA id g18-20020a170906395200b008c979c74732sm10364667eje.156.2023.03.24.08.20.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Mar 2023 08:20:26 -0700 (PDT) In-Reply-To: <87sfducmrc.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 24 Mar 2023 13:16:55 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258525 Archived-At: tag 62417 patch Jo=C3=A3o T=C3=A1vora writes: > I haven't yet investigated the reason. There are other use cases inside > SLY that are also failing with similar errors, but they are not as easy > to trigger. The simples way to fix this is to make display-buffer-assq-regexp keep the old protocol before trying `buffer-match-p'. diff --git a/lisp/window.el b/lisp/window.el index 2da2f8bb2c8..0932a05aabf 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -7502,8 +7502,13 @@ display-buffer-assq-regexp the form of the action argument passed to `display-buffer'." (catch 'match (dolist (entry alist) - (when (buffer-match-p (car entry) buffer-name action) - (throw 'match (cdr entry)))))) + (let ((key (car entry))) + (when (or (and (stringp key) + (string-match-p key buffer-name)) + (and (functionp key) + (funcall key buffer-name action)) + (buffer-match-p (car entry) buffer-name action)) + (throw 'match (cdr entry))))))) =20 (defvar display-buffer--same-window-action '(display-buffer-same-window Another way would be to fix this in buffer-match-p. Jo=C3=A3o