From: sbaugh@catern.com
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62700@debbugs.gnu.org, sbaugh@janestreet.com, juri@linkov.net
Subject: bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer
Date: Sat, 08 Apr 2023 10:58:36 +0000 (UTC) [thread overview]
Message-ID: <87o7nymyhw.fsf@catern.com> (raw)
In-Reply-To: <838rf2opa0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Apr 2023 09:34:47 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 62700@debbugs.gnu.org, Spencer Baugh <sbaugh@janestreet.com>
>> From: sbaugh@catern.com
>> Date: Fri, 07 Apr 2023 21:02:47 +0000 (UTC)
>>
>> Juri Linkov <juri@linkov.net> writes:
>> > Changing the API will definitely cause problems with backwards-compatibility.
>> > But maybe you could find a simple heuristic that would decide what base-suffix
>> > to set in minibuffer-completion-help? Then no API changes will be needed.
>>
>> Thank you for the guidance and suggestion.
>>
>> Here's one heuristic which works decently well:
>
> If this is for master, I'm fine with such changes. But if you intend
> to request installing this on emacs-29, then I will object making
> non-trivial changes in any code that is not specific to the M-<UP> and
> M-<DOWN> bindings that are new in Emacs 29. I don't want to risk any
> regressions in general-purpose completion code at this late stage.
OK, that's no problem, this can be done by just let-binding
completion-base-affixes in minibuffer-{previous,next,choose}-completion
so that it only affects new code. That will be a bit uglier to read so
I'll do that if this approach seems reasonable with some review.
next prev parent reply other threads:[~2023-04-08 10:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 17:56 bug#62700: 29.0.60; minibuffer-{previous,next,choose}-completion behave unintuitively when point is not at end of buffer Spencer Baugh
2023-04-06 18:22 ` Eli Zaretskii
2023-04-06 18:58 ` Spencer Baugh
2023-04-06 19:30 ` Eli Zaretskii
2023-04-06 20:42 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-06 18:55 ` Juri Linkov
2023-04-06 19:22 ` Spencer Baugh
2023-04-07 16:37 ` Juri Linkov
2023-04-07 21:02 ` sbaugh
2023-04-08 6:34 ` Eli Zaretskii
2023-04-08 10:58 ` sbaugh [this message]
2023-04-08 13:19 ` Eli Zaretskii
2023-04-08 18:36 ` Juri Linkov
2023-04-08 19:32 ` Eli Zaretskii
2023-04-09 16:40 ` Juri Linkov
2023-04-09 17:38 ` Eli Zaretskii
2023-04-08 18:30 ` Juri Linkov
[not found] ` <ierbk6lup79.fsf@janestreet.com>
2024-04-07 17:16 ` Juri Linkov
[not found] <b921ea5c-71a2-4e8f-b1cf-dd26831f8104@email.android.com>
2023-04-10 18:20 ` Juri Linkov
2023-04-20 16:52 ` Spencer Baugh
2023-04-20 18:18 ` Juri Linkov
2023-04-20 18:46 ` Spencer Baugh
2023-04-20 19:00 ` Eli Zaretskii
2023-04-21 18:56 ` sbaugh
2023-04-22 10:48 ` Eli Zaretskii
2023-04-22 12:57 ` sbaugh
2023-04-22 13:15 ` Eli Zaretskii
2023-04-22 21:38 ` sbaugh
2023-04-23 6:13 ` Eli Zaretskii
2023-04-23 11:48 ` sbaugh
2023-04-24 11:22 ` Eli Zaretskii
2023-05-02 15:13 ` sbaugh
2023-05-02 17:57 ` Eli Zaretskii
2023-05-08 15:48 ` Juri Linkov
2023-05-08 16:11 ` Eli Zaretskii
2023-06-03 0:58 ` Spencer Baugh
2023-06-04 7:09 ` Eli Zaretskii
2023-06-10 10:51 ` Eli Zaretskii
2023-06-12 18:27 ` Juri Linkov
2023-06-13 2:32 ` Eli Zaretskii
2023-06-13 16:54 ` Juri Linkov
2023-06-13 16:59 ` Eli Zaretskii
2023-06-13 20:59 ` Spencer Baugh
2023-06-14 17:32 ` Juri Linkov
2023-09-03 17:37 ` Juri Linkov
2023-09-04 0:30 ` sbaugh
2023-09-04 6:51 ` Juri Linkov
2023-11-14 7:39 ` Juri Linkov
2023-11-15 17:42 ` Juri Linkov
2023-04-20 18:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7nymyhw.fsf@catern.com \
--to=sbaugh@catern.com \
--cc=62700@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.