From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#62694: 30.0.50; eglot-tests fails with recent pylsp Date: Sun, 09 Apr 2023 16:48:52 +0100 Message-ID: <87o7nxf44b.fsf@gmail.com> References: <87sfddibcn.fsf@gmx.de> <87o7o1tfvc.fsf@gmx.de> <87ile5gv0c.fsf@tcd.ie> <874jppb388.fsf@tcd.ie> <87ttxpf725.fsf@gmail.com> <87pm8dcbr7.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11024"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Basil Contovounesios , 62694@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 09 17:47:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plXGA-0002b6-Ur for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Apr 2023 17:47:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plXFw-0000cu-Oe; Sun, 09 Apr 2023 11:47:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plXFv-0000cg-MQ for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 11:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plXFv-0003rq-0R for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 11:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plXFu-0006su-Eh for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62694 X-GNU-PR-Package: emacs Original-Received: via spool by 62694-submit@debbugs.gnu.org id=B62694.168105521726454 (code B ref 62694); Sun, 09 Apr 2023 15:47:02 +0000 Original-Received: (at 62694) by debbugs.gnu.org; 9 Apr 2023 15:46:57 +0000 Original-Received: from localhost ([127.0.0.1]:33564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plXFp-0006sb-9A for submit@debbugs.gnu.org; Sun, 09 Apr 2023 11:46:57 -0400 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:54155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plXFn-0006sM-HZ for 62694@debbugs.gnu.org; Sun, 09 Apr 2023 11:46:56 -0400 Original-Received: by mail-wm1-f49.google.com with SMTP id gw13so1694666wmb.3 for <62694@debbugs.gnu.org>; Sun, 09 Apr 2023 08:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681055209; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KoA3Cvz4cBoCotk+JAk3EjTqvwJdCEVLxi5R+M9ok5Y=; b=B/JyOeuDMMuqJPfxKNp0UG3nBxrK9vjX83qJJ6kNw19dTpmzzDlzEYmyMAB/u/12Px HmIfOvBXgsiEmDAyyQHOmzCGWQ1Qtv2LE0MNV/5Jy5Dd09lmlluU+2NPqBGrSEJRe4wW kfnNgfTI3HpbG5j7BSwOGNJLSPs4swHXfqr9Juuc0eZb2YS90azgB7mH6kApRYpYygIJ BuLQbasDiZSSJeO5YH7DFctLUTfRXFR3IvegHEm58Ywx/QhTgvt6dYayI7dahAQ0PByP HrtOsDj5Vj0KkpXUQB/Dk4h26TwukzYeSyHM69aY2c7LKbZHHPjjKyAAB94ockGoAdO5 mbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681055209; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KoA3Cvz4cBoCotk+JAk3EjTqvwJdCEVLxi5R+M9ok5Y=; b=wQDjFZ0BJlxPdMDFuZBC6A8vW4uQkJAwBWa3cbLGHkUq/5aTyll4upbQAVxfDZ2zxw 4rMp0BOaV6lYlxAadbdbMIo1UMmw3iKXuIuAQm6EkWMCyIS/bOjHpkeWcYjTqbvultm2 nLFNbxsddamMjMaQkh+OjAY3YqD2lduOOLRx7z4XCCm6x2hlaKo5wAgw9Tt+RwGwN55g iJXjOiR4DUKTrqdaDmnx1pkZW+zuabJKvopewhwuDqdpJukNWARTKqHeg92h+YqdXqHP XI9k0EXOk7bvL3DTUtCzXK1+lGo6smB7so4/uRz41qry+WV1lrkfXTKki54/HV3FQlfB z16Q== X-Gm-Message-State: AAQBX9dKBJ+3vUvLbeTdOfH5Q4VrD4rfwOrHjQEs51QKv1T26ND4PZ9h QfHEahN0nqFh++aFu0stxnR7HM1w60M= X-Google-Smtp-Source: AKy350bx6GvlwbGc7Ep9h076fOPmJGrBmXq8cDcVEk/iGtvISjyTgFbUtH+Ju+l1ezHgPN6k2U2mUA== X-Received: by 2002:a05:600c:c4:b0:3ed:f5d4:3bff with SMTP id u4-20020a05600c00c400b003edf5d43bffmr5942625wmm.38.1681055209451; Sun, 09 Apr 2023 08:46:49 -0700 (PDT) Original-Received: from krug (98.142.114.89.rev.vodafone.pt. [89.114.142.98]) by smtp.gmail.com with ESMTPSA id r13-20020a05600c458d00b003f07ddfc3dfsm8513198wmo.3.2023.04.09.08.46.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 08:46:48 -0700 (PDT) In-Reply-To: <87pm8dcbr7.fsf@gmx.de> (Michael Albinus's message of "Sun, 09 Apr 2023 17:32:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259524 Archived-At: Michael Albinus writes: > Jo=C3=A3o T=C3=A1vora writes: > > Hi Jo=C3=A3o, > >>> That earlier proposals were not complete, optimal, or up to yours or >>> anyone's standards does not warrant degrading them, IMO.=20=20 >> >> - vague: there are no details, just the idea of "checking if the server >> is up to the job". > > I've shown you the Eglot traces for one test case on both Debian pylsp > (failed) and Fedora pylsp (succeeded). I still have no idea whether the > Debian flavour is inside the LSP specs or not. But if it returns > out-of-spec replies, I guess eglot should raise an Emacs error > indicating this fact. It's _not_ an out-of-spec reply. It's just a insuficient in-spec reply from a poorly installed or configured server. The point of these tests, as I've explained multiple times, is not to test the servers, rather eglot.el's particularly its interactions with other emacs facilities, such as xref, completion, flymake etc. Any server will do, as long as it is reasonably well-behaved and predictable. That's why I switched to clangd and all this discussion is moot now. > Based on this fact, you could always catch this specific error in the > tests, and say that the server is not suited. Whether you shall skip > or err out the test then is something else; until now it isn't obvious > that a failed eglot test is due to the (possible) server misbehavior, > or due to an eglot error. At least this information should be shown. It's impossible to know that. You can design perfectly in-spec naughty servers breaking all of eglot tests. Or you can follow Eglot's maintainer advice to install versions of servers known to be working correctly. Heroically complexifying Eglot to detect misbehaving servers is a completely futile exercise. Jo=C3=A3o