From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 17:57:00 +0200 Message-ID: <87o7lkhdwz.fsf@gmail.com> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> <87sfawhj91.fsf@gmail.com> <83a5x4yci0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18986"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 17:58:06 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8jvi-0004mF-8u for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 17:58:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8juv-0001sE-Jd; Mon, 12 Jun 2023 11:57:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8juk-0001pz-Vl for emacs-devel@gnu.org; Mon, 12 Jun 2023 11:57:08 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8jui-0000Nd-TL; Mon, 12 Jun 2023 11:57:06 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-30fc42fcbc7so744595f8f.1; Mon, 12 Jun 2023 08:57:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686585422; x=1689177422; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=WeAbaKDxdwY2yqsmOsyAZwBdlMcCOaZPk1kXcfPygEQ=; b=qPPHfSaYhV6Oz1WkniNWDOLfBe90XM0Z8o+c0+T0hmOJ+ouY3b+uc8BWBhMnauNXWY ryQRHNomRFg5r2EaT6ftedvmsSS+0q5IUPVjHv2Giqu/mGhvrDO2DoBuN1W++G+dUfFK +aQfZg9fIqhyrpn/XBgZqU/dYaEcbzLbDIfZCXSK5YNl00Uw8oJ+EyyxXbZzdfMsoEjH tUQTZrv5MGw7o0tE47duj4VANo1Mn3Leamwv6x6BB/dxCeCLrMm3zshlg57mGGoj9qWr 9x1yb65OSPSS7nGxQ7v35mQomCGwRaLYc0hdwoHptLlsy9vHyGWrle6kK3mSF1ycK6j/ 7osA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686585422; x=1689177422; h=mime-version:message-id:date:gmane-reply-to-list:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WeAbaKDxdwY2yqsmOsyAZwBdlMcCOaZPk1kXcfPygEQ=; b=luzGkTeHMIHzSmfP6uBQcLqirn5d/LVf1TJ0eaWHlLb3fkO5fcS1SxUbRZiJNFbQN3 DKzc7p6I7P4xo0OGWLR2Uh2CFuV2suk1spnQhiTHCWX9o5sePklCsuaQm9fuN1o8sSw1 WIij7NIfeBl0jPX8VxSBaVDpREoYfwaJ9muT64gj9ZCJ1Hv7VjqDo828SA7Ij53Hili7 LVr0+OaPvJ8L/X5Ay/3V7f/HgkNQ10aOCDVg3ebnTmjhH0bRzJn9aFUzkCM989TY5lIr 0ORzFjg1AzAAeVI2+kK77hyyY8uapGiYndVoNRXS9VQam8acp+rsR7mFF/rokbP4mSqS U1EA== X-Gm-Message-State: AC+VfDyfTkguY/UX9b4hV3VCaIc3PKU2HAw3x1JkTPy7dhALrfTi+aNi p324Y/xnn1wFNlVniY3YctrO0Suq5Gg= X-Google-Smtp-Source: ACHHUZ4uwAKbd7yYL2zvXRz8OyovglSodiQ8Gnt/w/FyrrztdfOCPkC7G9SquXi7fuQK5Ktctnv5Gw== X-Received: by 2002:a05:6000:110e:b0:309:5068:9ebe with SMTP id z14-20020a056000110e00b0030950689ebemr3934069wrw.50.1686585421870; Mon, 12 Jun 2023 08:57:01 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id i1-20020a5d4381000000b0030c4d8930b1sm12757218wrq.91.2023.06.12.08.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 08:57:01 -0700 (PDT) In-Reply-To: <83a5x4yci0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2023 17:35:35 +0300") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=rpluim@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306753 Archived-At: >>>>> On Mon, 12 Jun 2023 17:35:35 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Michael Albinus , emacs-devel@gnu.org >> Date: Mon, 12 Jun 2023 16:01:46 +0200 >> Eli> Sorry, I have no idea what this failure means. In particular, the Eli> value is correct for the defcustom, and works in practice, and also Eli> fits the type of the defcustom (AFAICT). >> >> Are you sure? Eli> Sure about which part? About it fitting the type of the defcustom. Since the current value works for you, it appears the code is more lenient than the defcustom type indicates. Eli> Once again, if you see the problem, feel free to fix it, and thanks. The minimal fix would be: diff --git a/lisp/window.el b/lisp/window.el index 78b0787abdb..16f16a75418 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -8776,7 +8776,7 @@ display-comint-buffer-action :group 'windows :group 'comint) -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window +(defcustom display-tex-shell-buffer-action '(display-buffer-in-previous-window) "`display-buffer' action for displaying TeX shell buffers." :type display-buffer--action-custom-type :risky t Although if we went by analogy to `display-comint-buffer-action', it would have to be this: diff --git a/lisp/window.el b/lisp/window.el index 78b0787abdb..0213023e495 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -7575,6 +7575,13 @@ display-buffer--same-window-action Specifies to call `display-buffer-same-window'.") (put 'display-buffer--same-window-action 'risky-local-variable t) +(defvar display-buffer--in-previous-window-action + '(display-buffer-in-previous-window + (inhibit-same-window . t)) + "A `display-buffer' action for displaying in the previous window. +Specifies to call `display-buffer-in-previous-window'.") +(put 'display-buffer--in-previous-window-action 'risky-local-variable t) + (defvar display-buffer--other-frame-action '((display-buffer-reuse-window display-buffer-pop-up-frame) @@ -8776,7 +8783,7 @@ display-comint-buffer-action :group 'windows :group 'comint) -(defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-window +(defcustom display-tex-shell-buffer-action display-buffer--in-previous-window-action "`display-buffer' action for displaying TeX shell buffers." :type display-buffer--action-custom-type :risky t Robert --