From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#64975: 30.0.50; accept-process-output and async connect Date: Tue, 08 Aug 2023 11:10:18 +0200 Message-ID: <87o7jhaohx.fsf@gmail.com> References: <838rapu9fu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12562"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64975@debbugs.gnu.org, Helmut Eller To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 11:11:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTIkG-00035o-9O for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 11:11:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTIk5-00036Y-NR; Tue, 08 Aug 2023 05:11:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTIk3-00036H-2L for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:11:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTIk2-0003U5-RH for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTIk2-0004Y6-AP for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 05:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64975 X-GNU-PR-Package: emacs Original-Received: via spool by 64975-submit@debbugs.gnu.org id=B64975.169148582817443 (code B ref 64975); Tue, 08 Aug 2023 09:11:02 +0000 Original-Received: (at 64975) by debbugs.gnu.org; 8 Aug 2023 09:10:28 +0000 Original-Received: from localhost ([127.0.0.1]:35149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTIjU-0004XG-61 for submit@debbugs.gnu.org; Tue, 08 Aug 2023 05:10:28 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:44324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTIjR-0004X3-So for 64975@debbugs.gnu.org; Tue, 08 Aug 2023 05:10:27 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so45655265e9.1 for <64975@debbugs.gnu.org>; Tue, 08 Aug 2023 02:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691485820; x=1692090620; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VRXOvAYmtIeVwWGWzo5H3rB/pFt+b+HprJjmjGpNow4=; b=DHEc3EKCzvtAFrS0oYQdJbNUvPivVfkeXPfD2ZbeAacbwT/dCm0QX9YmwvbpYR3kjy AgKWcttuiiAq9O6G/AGiSFoTB+ixqB5EwapyvjTJkPieLCFWWCiPQ4cmrtuNv9Rw0IpM QTT/NmHQMiD22jgBfcRJbI6WjZKGuWB2tOhWOlIWmqjChEXreoh06uDancCMlpakPqsb qQ4o+yMRSS/bR9+HeCqfKGMuu3s2wNL90OQ+t2wYeIj8ABJxDRXQgtHxYhXzMbB+Q9J0 NnSVK6VKPZmleYzoIloBD2OoSzWkzvFi+eDqHhE+oWN2IbpTpm9Zsb6g6ouglVpDFXPn mU7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691485820; x=1692090620; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRXOvAYmtIeVwWGWzo5H3rB/pFt+b+HprJjmjGpNow4=; b=BqY/36U7v8c92jQ414aLij7oqFf9oQLvapVOUtOimJpCrOULYBABI3YVGDoXJF1PUx nWGXaA9dRWAVEd6fReAxM2jlMu/NbE31LKBuO/ekuHuoyMG5Ez6uBXOHHoyfAfGVIvgs oIUdqsf3qvSIPNQfktId1e//uWyugnlhdn5uFelmYhd0yvyCPnmllC/7ubFu//FXW7/A vBnxi/NtBmcMguVmihga4ZiEo+dRHMFJUw1594cvsI26ffKT/rF9fUlBZl+ZG96AxGI/ kCiM2oP+mcHmvIgfkvO1EdnH1HpriegexHy972U6sgO3+6h8kQVGxq5c2SSXkt0G22/P UUDw== X-Gm-Message-State: AOJu0YztE4UCqyb4x4kcA+pFrtn/SnLElOlAajIAbEgJGftWp77KsS9T b/1zRc6u6FRnDWJ41oERoigLbSDcXTs= X-Google-Smtp-Source: AGHT+IFQ9Wx2ArALzjgklJDIENdsPnS8/N7OENXfNEVOSCMGSdl/NSgKCiP39bGK3Jg9++BpI0dUQQ== X-Received: by 2002:a05:6000:c5:b0:314:172b:a7d5 with SMTP id q5-20020a05600000c500b00314172ba7d5mr7971490wrx.27.1691485819599; Tue, 08 Aug 2023 02:10:19 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:602c:69f4:ec01:92cc]) by smtp.gmail.com with ESMTPSA id c3-20020a5d5283000000b003179d7ed4f3sm13092150wrv.12.2023.08.08.02.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 02:10:18 -0700 (PDT) In-Reply-To: <838rapu9fu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Aug 2023 12:26:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266923 Archived-At: >>>>> On Sat, 05 Aug 2023 12:26:13 +0300, Eli Zaretskii said: >> From: Helmut Eller >> Date: Mon, 31 Jul 2023 15:31:00 +0200 >>=20 >> (ert-deftest async-connect () >> (let* ((host 'local) >> (family 'ipv4) >> (port 57869) >> (server (make-network-process >> :name "server" :server t :noquery t :reuseaddr t >> :host host :service port :family family)) >> (proc (make-network-process >> :name "async-connect" :nowait t >> :host host :service port :family family))) >> (should (eq (process-status proc) 'connect)) >> (should (accept-process-output proc 2)) >> (should (eq (process-status proc) 'open)))) >>=20 >> when executed with >> emacs --batch -Q -l async-connect.el -f ert-run-tests-batch-and-exit >>=20 >> It seems that accept-process-output correctly updates the process-st= atus >> but it forgets to break out of the loop. >>=20 >> With the following change, the test passes: Eli> Robert, any comments? I go away for a week, and this is what you give me as a coming-back present? :-) I think it=CA=BCs correct, as I have a change locally setting got_some_output for a different test case, but I=CA=BCm going to be a pain, and ask Helmut to explain why, and see if I agree with his explanation (that=CA=BCs a very hairy loop) Robert --=20