From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#65704: [PATCH] project.el: Fix bug in project-ignores Date: Sat, 02 Sep 2023 18:17:33 +0200 Message-ID: <87o7iklfc2.fsf@cassou.me> References: <87sf7wlg07.fsf@cassou.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34612"; mail-complaints-to="usenet@ciao.gmane.io" To: 65704@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 18:18:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcTKA-0008o8-AX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 18:18:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcTJr-0002YS-Hf; Sat, 02 Sep 2023 12:17:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTJp-0002Xn-Dc for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:17:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcTJp-0004nS-5O for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:17:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcTJy-0006kV-V7 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:18:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87sf7wlg07.fsf@cassou.me> Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65704 X-GNU-PR-Package: emacs Original-Received: via spool by 65704-submit@debbugs.gnu.org id=B65704.169367147025902 (code B ref 65704); Sat, 02 Sep 2023 16:18:02 +0000 Original-Received: (at 65704) by debbugs.gnu.org; 2 Sep 2023 16:17:50 +0000 Original-Received: from localhost ([127.0.0.1]:38318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTJl-0006jh-MU for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:17:49 -0400 Original-Received: from mail.choca.pics ([80.67.172.235]:34428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTJj-0006jY-Ei for 65704@debbugs.gnu.org; Sat, 02 Sep 2023 12:17:48 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id B506D181929E9 for <65704@debbugs.gnu.org>; Sat, 2 Sep 2023 18:17:35 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10032) with ESMTP id sLnQ4zzTAy1S for <65704@debbugs.gnu.org>; Sat, 2 Sep 2023 18:17:35 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 15CDB18193F46 for <65704@debbugs.gnu.org>; Sat, 2 Sep 2023 18:17:35 +0200 (CEST) X-Virus-Scanned: amavis at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10026) with ESMTP id t_2v6s8FvfRe for <65704@debbugs.gnu.org>; Sat, 2 Sep 2023 18:17:34 +0200 (CEST) Original-Received: from localhost (91.60.75.86.rev.sfr.net [86.75.60.91]) by mail.choca.pics (Postfix) with ESMTPSA id 6DA36181929E9 for <65704@debbugs.gnu.org>; Sat, 2 Sep 2023 18:17:34 +0200 (CEST) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269007 Archived-At: --=-=-= Content-Type: text/plain In case what I said in the issue's description is correct, please find attach a possible patch. -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-project.el-Fix-bug-in-project-ignores.patch >From f04731cc2a31510163dc2ed484f47467ea88f036 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Sat, 2 Sep 2023 18:08:49 +0200 Subject: [PATCH] project.el: Fix bug in project-ignores The variable `backend' was always nil preventing the 25-line long `when' block to do anything. This bug seems to have been introduced in commit 785fa801596ad7bb9f838cac865f00de29e253d1 "New user option: project-vc-extra-root-markers". (Bug#65704) * lisp/progmodes/project.el: (project-ignores) Use backend-specific code if possible. --- lisp/progmodes/project.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 37db677943a..29a81c7e151 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -733,11 +733,10 @@ project--git-submodules (cl-defmethod project-ignores ((project (head vc)) dir) (let* ((root (nth 2 project)) - backend) + (backend (cadr project))) (append (when (and backend (file-equal-p dir root)) - (setq backend (cadr project)) (delq nil (mapcar -- 2.41.0 --=-=-=--