From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Date: Thu, 15 Feb 2024 08:53:00 +0100 Message-ID: <87o7ciupsz.fsf@runbox.com> References: <87sf5ge0v6.fsf@runbox.com> <87a5pl1qym.fsf@runbox.com> <87y1d0p9ic.fsf@runbox.com> <874jfibkju.fsf@runbox.com> <87eded2270.fsf@runbox.com> <87sf24l6cv.fsf@runbox.com> Reply-To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11587"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67000-done@debbugs.gnu.org, Eli Zaretskii To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 08:56:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raWbB-0002mK-51 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 08:56:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raWax-0006Uc-3d; Thu, 15 Feb 2024 02:55:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raWau-0006UM-Lf for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 02:55:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raWau-0005fM-D0 for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 02:55:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raWbC-00083V-In for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 02:56:02 -0500 Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 07:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 67000@debbugs.gnu.org, simenheg@runbox.com, simenheg@runbox.com Original-Received: via spool by 67000-done@debbugs.gnu.org id=D67000.170798374630937 (code D ref 67000); Thu, 15 Feb 2024 07:56:02 +0000 Original-Received: (at 67000-done) by debbugs.gnu.org; 15 Feb 2024 07:55:46 +0000 Original-Received: from localhost ([127.0.0.1]:53913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raWaw-00082v-Fg for submit@debbugs.gnu.org; Thu, 15 Feb 2024 02:55:46 -0500 Original-Received: from mailtransmit05.runbox.com ([185.226.149.38]:58252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raWau-00082g-Co for 67000-done@debbugs.gnu.org; Thu, 15 Feb 2024 02:55:45 -0500 Original-Received: from mailtransmit02.runbox ([10.9.9.162] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1raWYO-003d9O-RL for 67000-done@debbugs.gnu.org; Thu, 15 Feb 2024 08:53:08 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From; bh=4xQF56DpY7xF7JfOJHaLtGGTdswnTjNSHhUMF8CeMf4=; b=t8MMxrrO6v+7CzXqVij7S63ZLz p7q8IiFA5BJpnaywqGr9pc3rr+bICwxC/dCX+tTRFBvrTxVL+piNvFJnKyMTFrm7nDwFttj6SzIj8 Pz/5glSruAWQLvgAUHMhJyJp3f+69sFyI2QrKi92Nvn28gGgHNULmQqQDuo/YP+k7SiU9CGn3PO1k zB2Kjasjf+OZLdIg0gJXJJEbJ7Bfrk0i4V3rYwm//yBWGPGa6ZdaWHbIu01Vj1VLZuLsncQC6dPPO 0268349LjzXkP54RZejYvV/be1sKy8AH0Wy5qEABO7S5ChmLAojBCtfWFRRiDWtZE/j7PNKPMLlTF i2s/29EQ==; Original-Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1raWYO-00057d-80; Thu, 15 Feb 2024 08:53:08 +0100 Original-Received: by submission03.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1raWYG-00C0z4-Q6; Thu, 15 Feb 2024 08:53:00 +0100 In-Reply-To: (Stefan Kangas's message of "Sat, 10 Feb 2024 05:28:27 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280045 Archived-At: Stefan Kangas writes: > LGTM, please install. Done! Thanks again for reviewing. >>>> +(defcustom ielm-history-file-name >>>> + (locate-user-emacs-file "ielm-history.eld") >>>> + "If non-nil, name of the file to read/write IELM input history." >>>> + :type '(choice (const :tag "nil" nil) >>> >>> The tag here should be "Disable input history" or something like that. >> >> Ok. Should it be updated for `comint-input-ring-file-name' too then (I >> copied it from there)? > > Yes, that could be improved too. Done. >> From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= >> Date: Tue, 16 Jan 2024 08:21:41 +0100 >> Subject: [PATCH] Add support for reading/writing IELM input history >> >> * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for >> reading/writing input history. > > How about: > > "Add support for saving input history to a file" Changed. >> (ielm--history-file-name): Name of the file to read/write IELM input >> history. > > Maybe: > > "New variable indicating IELM input history file. Changed. >> +(defcustom ielm-history-file-name >> + (locate-user-emacs-file "ielm-history.eld") >> + "If non-nil, name of the file to read/write IELM input history." >> + :type '(choice (const :tag "Disable input history" nil) >> + file) >> + :version "30.1") > > Maybe `file' should have a tag too? The label in the Custom menu says "File", which seems fine to me? Though I never use Custom, so I'm not sure what's customary here. I installed the above without changes, but please feel free to change it. -- Simen