From: "Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 67000-done@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history
Date: Thu, 15 Feb 2024 08:53:00 +0100 [thread overview]
Message-ID: <87o7ciupsz.fsf@runbox.com> (raw)
In-Reply-To: <CADwFkm=UVzis24y4-VRVYvmXotdEWOX+3h31O+uYmUQMY3=s0g@mail.gmail.com> (Stefan Kangas's message of "Sat, 10 Feb 2024 05:28:27 -0600")
Stefan Kangas <stefankangas@gmail.com> writes:
> LGTM, please install.
Done! Thanks again for reviewing.
>>>> +(defcustom ielm-history-file-name
>>>> + (locate-user-emacs-file "ielm-history.eld")
>>>> + "If non-nil, name of the file to read/write IELM input history."
>>>> + :type '(choice (const :tag "nil" nil)
>>>
>>> The tag here should be "Disable input history" or something like that.
>>
>> Ok. Should it be updated for `comint-input-ring-file-name' too then (I
>> copied it from there)?
>
> Yes, that could be improved too.
Done.
>> From fe91c4f3aaefc109135c48ba26f8f21e87db465e Mon Sep 17 00:00:00 2001
>> From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
>> Date: Tue, 16 Jan 2024 08:21:41 +0100
>> Subject: [PATCH] Add support for reading/writing IELM input history
>>
>> * lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
>> reading/writing input history.
>
> How about:
>
> "Add support for saving input history to a file"
Changed.
>> (ielm--history-file-name): Name of the file to read/write IELM input
>> history.
>
> Maybe:
>
> "New variable indicating IELM input history file.
Changed.
>> +(defcustom ielm-history-file-name
>> + (locate-user-emacs-file "ielm-history.eld")
>> + "If non-nil, name of the file to read/write IELM input history."
>> + :type '(choice (const :tag "Disable input history" nil)
>> + file)
>> + :version "30.1")
>
> Maybe `file' should have a tag too?
The label in the Custom menu says "File", which seems fine to me? Though
I never use Custom, so I'm not sure what's customary here. I installed
the above without changes, but please feel free to change it.
-- Simen
prev parent reply other threads:[~2024-02-15 7:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:11 bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-15 1:06 ` Stefan Kangas
2024-01-04 7:46 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 20:17 ` Stefan Kangas
2024-01-08 7:30 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 19:51 ` Stefan Kangas
2024-01-12 16:09 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 7:08 ` Stefan Kangas
2024-01-19 7:48 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 15:09 ` Stefan Kangas
2024-02-07 14:02 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 11:28 ` Stefan Kangas
2024-02-15 7:53 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ciupsz.fsf@runbox.com \
--to=bug-gnu-emacs@gnu.org \
--cc=67000-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=simenheg@runbox.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.