From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67955: [PATCH] Add use-package-vc-prefer-newest user option Date: Sat, 30 Mar 2024 09:15:32 +0100 Message-ID: <87o7aw6spn.fsf@hyperspace> References: <87a5q3bf0e.fsf@hyperspace> <87a5paldfy.fsf@posteo.net> <878r4t18in.fsf@hyperspace> <87fryzxecx.fsf@posteo.net> <87h6jecpyk.fsf@hyperspace> <87ply1g2b0.fsf@posteo.net> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Kangas , 67955@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 30 09:16:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rqTt4-0008oh-4X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Mar 2024 09:16:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rqTsj-0002qJ-7B; Sat, 30 Mar 2024 04:16:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rqTsf-0002pt-Hs for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 04:16:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rqTsf-0006JC-8X for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 04:16:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rqTsg-0006Rp-0d for bug-gnu-emacs@gnu.org; Sat, 30 Mar 2024 04:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Mar 2024 08:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67955-submit@debbugs.gnu.org id=B67955.171178655824770 (code B ref 67955); Sat, 30 Mar 2024 08:16:01 +0000 Original-Received: (at 67955) by debbugs.gnu.org; 30 Mar 2024 08:15:58 +0000 Original-Received: from localhost ([127.0.0.1]:43885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqTsY-0006RM-Vd for submit@debbugs.gnu.org; Sat, 30 Mar 2024 04:15:58 -0400 Original-Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]:34634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqTsT-0006QT-Mh for 67955@debbugs.gnu.org; Sat, 30 Mar 2024 04:15:54 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4V697p18pnz9sWs; Sat, 30 Mar 2024 09:15:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1711786534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gdAKUqAGP8G05KYfpemxBNmSFiWdT6m4sGsZmpr03GI=; b=Wju+NqZhGL/SfpvU1U/6nspAJlivZsyAyVv6cfb/Ego7g1+uwSv3Wj82tSrJIw7ZhLybKl rtLrYV4k/blty2NlwxTo/afrZR7e4vahHp1JyQ2o87v4nqpEp/LpnMIMyJEJ8GLgRYw1+5 GSVW1dUpdGzBRigNc6PPwNWQMLsUBJ24M05WY8jCviD1RNSxc0ecA6ZjrSl73s/xA8f3kd rPMG4VYSxjpItQbJPfTVBjKLGJE+/6E6d9dosryT/pfqpeYq4y7OyfKKLDWaCzRbIdGLe7 6wFtZdtHL4J7Lvrr9aZ89J1iVHqR8ZmaRCGXV1P9W4SU8KZkmUOoqwzLuw4QcQ== In-Reply-To: <87ply1g2b0.fsf@posteo.net> X-MBO-RS-ID: 8f14a07780e52939b21 X-MBO-RS-META: 4cx43d3c1w7qm3j9skmj8yo3tpitj4gu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282334 Archived-At: On Tue, Jan 16 2024 07:33, Philip Kaludercic wrote: > Tony Zorman writes: > > > [...] > >>> Yes, that was what I meant. I don't want to assume that users are >>> familiar with MELPA, so a brief comment to that effect should suffice. >>> Thanks! >> >> Okay, I've attached a new version of the patch. >> >> Thanks for the review! >> T >> >> From 8f207a132f669cf2486ecf0e12ade864a9a6912c Mon Sep 17 00:00:00 2001 >> From: Tony Zorman >> Date: Thu, 21 Dec 2023 17:51:09 +0100 >> Subject: [PATCH] Add use-package-vc-prefer-newest user option >> >> * lisp/use-package/use-package-core.el (use-package-vc-prefer-newest): >> User option to prefer the latest commit (as opposed to the latest >> release) of a package. >> (use-package-normalize--vc-arg): Check for >> use-package-vc-prefer-newest. >> >> * doc/misc/use-package.texi (Install package): Document >> use-package-vc-prefer-newest. >> >> * etc/NEWS: Document use-package-vc-prefer-newest. >> --- >> doc/misc/use-package.texi | 8 ++++++-- >> etc/NEWS | 5 +++++ >> lisp/use-package/use-package-core.el | 22 +++++++++++++++++++--- >> 3 files changed, 30 insertions(+), 5 deletions(-) >> >> diff --git a/doc/misc/use-package.texi b/doc/misc/use-package.texi >> index d834e1be754..c2b6404b68b 100644 >> --- a/doc/misc/use-package.texi >> +++ b/doc/misc/use-package.texi >> @@ -1639,8 +1639,12 @@ Install package >> would try -- by invoking @code{package-vc-install} -- to install the >> latest commit of the package @code{foo} from the specified remote. >> >> -This can also be used for local packages, by combining it with the >> -@code{:load-path} (@pxref{Load path}) keyword: >> +@vindex use-package-vc-prefer-newest >> +Alternatively, the @code{use-package-vc-prefer-newest} user option >> +exists to always prefer the latest commit. >> + >> +The @code{:vc} keyword can also be used for local packages, by >> +combining it with @code{:load-path} (@pxref{Load path}): >> >> @example >> @group >> diff --git a/etc/NEWS b/etc/NEWS >> index 03b8c3b517a..f9e01b14f92 100644 >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -1035,6 +1035,11 @@ interactive Python interpreter specified by 'python-interpreter'. >> *** New ':vc' keyword. >> This keyword enables the user to install packages using 'package-vc'. >> >> ++++ >> +*** New user option 'use-package-vc-prefer-newest'. >> +This allows the user to always install the newest commit of a package >> +when using the ':vc' keyword. >> + >> ** Gnus >> >> *** The 'nnweb-type' option 'gmane' has been removed. >> diff --git a/lisp/use-package/use-package-core.el b/lisp/use-package/use-package-core.el >> index d9343e14839..ba2e93c97e9 100644 >> --- a/lisp/use-package/use-package-core.el >> +++ b/lisp/use-package/use-package-core.el >> @@ -346,6 +346,20 @@ use-package-compute-statistics >> :type 'boolean >> :group 'use-package) >> >> +(defcustom use-package-vc-prefer-newest nil >> + "Prefer the newest commit over the latest release. >> +By default, much like GNU ELPA and NonGNU ELPA, the `:vc' keyword >> +tracks the latest stable release of a package. If this option is >> +non-nil, the latest commit is preferred instead. This has the >> +same effect as specifying `:rev :newest' in every invocation of >> +`:vc'. >> + >> +Note that always tracking a package's latest commit might lead to >> +stability issues." >> + :type 'boolean >> + :version "30.1" >> + :group 'use-package) > > Sounds good to me, I think the patch can be merged. Any objections? I guess not? :) Tony -- Tony Zorman | https://tony-zorman.com/