From: "J.P." <jp@neverwas.me>
To: Javier Olaechea <pirata@gmail.com>
Cc: 70145@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#70145: [PATCH] Add sqlite-execute-batch command
Date: Tue, 02 Apr 2024 18:56:54 -0700 [thread overview]
Message-ID: <87o7arciop.fsf@neverwas.me> (raw)
In-Reply-To: <CAFVS=zBqFWwBSDkk7xK_O4faXUTiXFVA2SMdvXGxppLf_THAKA@mail.gmail.com> (Javier Olaechea's message of "Tue, 2 Apr 2024 14:10:15 -0500")
Hi Javier,
Thanks for working on this. I think Emacs applications will find it
handy for things like initializing a new database. Just a couple things
I spotted in passing. (I don't really know anything, though, so feel
free to ignore.)
Javier Olaechea <pirata@gmail.com> writes:
> * test/lisp/sqlite-tests.el (with-sqlite-execute-batch-test): Test it.
~~~~
I think there's also a test/src/sqlite-tests.el file, which seems to
contain tests for those primitives defined in src/sqlite.c. Perhaps this
test should go there instead?
> diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el
> index d4892a27efc..7053026eb82 100644
> --- a/test/lisp/sqlite-tests.el
> +++ b/test/lisp/sqlite-tests.el
> @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback
> ;; First insertion (a=1) rolled back.
> (should-not (sqlite-select db "select * from test"))))
>
> +(ert-deftest with-sqlite-execute-batch-test ()
Maybe I'm mistaken, but I don't think you need the "with-" part (or the
"-test" part), no?
next prev parent reply other threads:[~2024-04-03 1:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 15:03 bug#70145: [PATCH] Add sqlite-execute-batch command Javier Olaechea
2024-04-02 16:21 ` Eli Zaretskii
2024-04-02 18:52 ` Javier Olaechea
2024-04-02 18:56 ` Eli Zaretskii
2024-04-02 19:10 ` Javier Olaechea
2024-04-03 1:56 ` J.P. [this message]
2024-04-03 2:42 ` Javier Olaechea
2024-04-13 8:03 ` Eli Zaretskii
2024-04-14 3:32 ` Javier Olaechea
2024-04-14 5:52 ` Eli Zaretskii
2024-06-06 8:00 ` Javier Olaechea
2024-06-06 10:08 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7arciop.fsf@neverwas.me \
--to=jp@neverwas.me \
--cc=70145@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pirata@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.